golang-osd-e2e: derive e2e Dockerfile WORKDIR from go.mod#757
golang-osd-e2e: derive e2e Dockerfile WORKDIR from go.mod#757MitaliBhalla wants to merge 1 commit into
Conversation
Use the module path from go.mod instead of OperatorName so repos like MCWV build with the correct GOPATH layout. Bump default Go builder images to 1.26 to match current operator go.mod/toolchain versions. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MitaliBhalla The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary
golang-osd-e2e/updatereadsWORKDIRfromgo.modmodule path instead ofconfig/config.goOperatorName(fixes MCWV and any repo where those differ)rhel_9_1.26/golang-1.26-openshift-4.22) to match current operatorgo.modand Konflux.tektonBASE_IMAGEMotivation
Hand-editing generated
test/e2e/Dockerfilein consumer repos is fragile and gets flagged in review. MCWV e2e Konflux builds failed on Go 1.25 builder whilego.modis 1.26.Test plan
KONFLUX_BUILDS=true ./boilerplate/openshift/golang-osd-e2e/update POSTonmanaged-cluster-validating-webhooksproduces Dockerfile with correct module path andrhel_9_1.26builderOperatorName ==repo name (no WORKDIR change expected)Made with Cursor