Skip to content

golang-osd-e2e: derive e2e Dockerfile WORKDIR from go.mod#757

Open
MitaliBhalla wants to merge 1 commit into
openshift:masterfrom
MitaliBhalla:rosa-745-golang-osd-e2e-dockerfile
Open

golang-osd-e2e: derive e2e Dockerfile WORKDIR from go.mod#757
MitaliBhalla wants to merge 1 commit into
openshift:masterfrom
MitaliBhalla:rosa-745-golang-osd-e2e-dockerfile

Conversation

@MitaliBhalla

Copy link
Copy Markdown
Contributor

Summary

  • golang-osd-e2e/update reads WORKDIR from go.mod module path instead of config/config.go OperatorName (fixes MCWV and any repo where those differ)
  • Bump e2e builder images to Go 1.26 (rhel_9_1.26 / golang-1.26-openshift-4.22) to match current operator go.mod and Konflux .tekton BASE_IMAGE

Motivation

Hand-editing generated test/e2e/Dockerfile in consumer repos is fragile and gets flagged in review. MCWV e2e Konflux builds failed on Go 1.25 builder while go.mod is 1.26.

Test plan

  • KONFLUX_BUILDS=true ./boilerplate/openshift/golang-osd-e2e/update POST on managed-cluster-validating-webhooks produces Dockerfile with correct module path and rhel_9_1.26 builder
  • Spot-check another operator where OperatorName == repo name (no WORKDIR change expected)

Made with Cursor

Use the module path from go.mod instead of OperatorName so repos like
MCWV build with the correct GOPATH layout. Bump default Go builder
images to 1.26 to match current operator go.mod/toolchain versions.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • boilerplate/openshift/golang-osd-e2e/update is excluded by !boilerplate/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ceac8655-4b93-4536-a814-04f273194801

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci

openshift-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MitaliBhalla
Once this PR has been reviewed and has the lgtm label, please assign yiqinzhang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant