Add init container to e2e template for SAPM image gate#752
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/hold for testing |
joshbranham
left a comment
There was a problem hiding this comment.
This lgtm as a interim step to prevent flakes in e2e's. I presumed we had a better way to do this in Tekton + App-Interface, but as discussed on Slack, we've exhausted steps there.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustman9000, joshbranham The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
Adds an init container to the osde2e focused test Job template that references the test image (
${TEST_IMAGE}:${IMAGE_TAG}). This makes the image visible to qontract-reconcile's_collect_imagesscanner, which validates all container images exist before deploying.Problem
The test image reference is embedded in a YAML string inside the
TEST_SUITES_YAMLenv var. The_collect_imagesscanner only checksspec.template.spec.containers[].imageandinitContainers[].image, so it never finds the test image.When SAPM auto-promotes the e2e saas file after a PKO deploy, the e2e Job deploys before the Konflux release pipeline finishes pushing the test image to the production registry, causing
manifest unknownerrors.Fix
The init container runs
trueand exits immediately. Its only purpose is to surface the test image reference as a proper container image field so the SAPM image check blocks deployment until the image exists.Benefits all operators using the
golang-osd-e2eboilerplate convention.