Skip FinalClass when class has anonymous inner subclasses#886
Merged
Conversation
A class with only private constructors can still be subclassed from within its own body via anonymous classes. Making such a class `final` produces uncompilable code. Fixes #885
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FinalClasswas incorrectly addingfinalto classes whose private constructors are used from anonymous inner subclasses defined within the class body, producing uncompilable code.The visitor now records the supertype of any anonymous class as a type that must not be finalized, mirroring how named subclass supertypes are already excluded.
Fixes FinalClass adds final to classes with anonymous inner subclasses when all constructors are private #885
Test plan
./gradlew test --tests FinalClassTest(newdoNotFinalizeClassWithAnonymousSubclassplus existing scenarios)