relay: fix LF onTrackEvicted no-op and local-forwarder seed-read race#452
Open
afrind wants to merge 1 commit into
Open
relay: fix LF onTrackEvicted no-op and local-forwarder seed-read race#452afrind wants to merge 1 commit into
afrind wants to merge 1 commit into
Conversation
In LocalForwarder mode onTrackEvicted looked up a session-keyed subscriber on the registry's publisher forwarder, but the subscriber lives on the per-thread local forwarder (exec-keyed channel subscribers on the publisher fwd) — so it silently evicted nothing and never sent publishDone. Branch on mode(): hop to session's exec, resolve the local forwarder, and evict there. Also seed a new local forwarder's largest/extensions from a publisherExec hop instead of reading them on subscriberExec while the publisher advances largest_. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In LocalForwarder mode onTrackEvicted looked up a session-keyed subscriber on the registry's publisher forwarder, but the subscriber lives on the per-thread local forwarder (exec-keyed channel subscribers on the publisher fwd) — so it silently evicted nothing and never sent publishDone. Branch on mode(): hop to session's exec, resolve the local forwarder, and evict there.
Also seed a new local forwarder's largest/extensions from a publisherExec hop instead of reading them on subscriberExec while the publisher advances largest_.
This change is