Skip to content

relay: deepen datagram send queue and drop oldest-first #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
afrind wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

relay: deepen datagram send queue and drop oldest-first #450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/MoqxRelayServer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,10 @@ buildTransportSettings(const config::QuicConfig& quic, const config::MvfstConfig
ts.advertisedInitialUniStreamFlowControlWindow = quic.maxStreamData;
ts.advertisedInitialMaxStreamsBidi = quic.maxBidiStreams;
ts.advertisedInitialMaxStreamsUni = quic.maxUniStreams;
// Deep datagram queue dropping oldest-first: a write stall sheds stale frames
// rather than rejecting new ones.
ts.datagramConfig.writeBufSize = 500;
ts.datagramConfig.sendDropOldDataFirst = true;
ts.idleTimeout = std::chrono::milliseconds(quic.idleTimeoutMs);
ts.minAckDelay = std::chrono::microseconds(quic.minAckDelayUs);
if (quic.maxAckDelayUs != config::QuicConfig{}.maxAckDelayUs) {
Expand Down
4 changes: 4 additions & 0 deletions src/UpstreamProvider.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,10 @@ folly::coro::Task<void> UpstreamProvider::doConnect() {

quic::TransportSettings ts;
ts.orderedReadCallbacks = true;
// Deep datagram queue dropping oldest-first: a write stall sheds stale frames
// rather than rejecting new ones.
ts.datagramConfig.writeBufSize = 1000;
ts.datagramConfig.sendDropOldDataFirst = true;

// Relay chaining requires draft 16+. Only offer standard draft-16 ALPN
// ("moqt-16") so we fail fast if the upstream doesn't support it.
Expand Down
Loading