Skip to content

ci(test-reporter): list only failed tests to avoid 64 KiB Check Run cap#448

Merged
gmarzot merged 1 commit into
mainfrom
hotfix/test-reporter-trim
Jun 26, 2026
Merged

ci(test-reporter): list only failed tests to avoid 64 KiB Check Run cap#448
gmarzot merged 1 commit into
mainfrom
hotfix/test-reporter-trim

Conversation

@gmarzot

@gmarzot gmarzot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Summary

The test (macos) Check Run on PR #437 (and any other PR with a large test suite) hits GitHub's hard cap of 65 535 bytes on Check Run output bodies and gets trimmed:

Report exceeded GitHub limit of 65535 bytes and has been trimmed

Cause: dorny/test-reporter defaults to list-tests: all, which emits every passing test name (672 of them in our case) alongside the 1 failing one. With 673 entries the markdown body sails past 64 KiB.

Fix: set list-tests: failed in both ci-pr.yml and ci-main.yml. Only failing tests get listed in the Check Run summary; the per-suite pass/fail/skip counts at the top still render, so reviewers still see "672 passed, 1 failed" at a glance — they just don't have to scroll through 600+ ✅ rows to find the ❌.

What stays / what changes

Before After
Per-suite header counts (passed/failed/skipped/time) ✅ shown ✅ shown
List of FAILING tests ✅ shown ✅ shown
List of PASSING tests ✅ all 672 shown ❌ hidden
Trimmed by GitHub ⚠️ yes, at 64 KiB ✅ no

Test plan

  • Merge → next PR push triggers test (linux/macos/asan debug) jobs
  • Confirm Check Run output is under 64 KiB and not annotated as trimmed
  • Confirm failing tests (if any) still appear in the Check Run summary

This change is Reviewable

The 'test (macos)' Check Run on PR #437 hit the GitHub 65535-byte limit
on Check Run output bodies — the dorny/test-reporter default lists all
672 passing test names alongside the 1 failing one, blowing the cap and
truncating the report.

Pass list-tests: failed in both ci-pr.yml and ci-main.yml so the
summary lists only the failing tests. The per-suite pass/fail/skip
counts at the top still render, so reviewers still see 'X passed, Y
failed' at a glance — they just don't have to scroll through 600+
passing-test rows underneath.

@afrind afrind left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afrind reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on gmarzot).

@gmarzot gmarzot merged commit 13b37c8 into main Jun 26, 2026
16 checks passed
@gmarzot gmarzot deleted the hotfix/test-reporter-trim branch June 26, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants