Automatically register IOptionsChangeTokenSource<TOptions> implementations to enable cascade re-evaluation of options#2479
Merged
Conversation
…tions to enable cascade re-evaluation of options
kevinchalet
changed the title
IOptionsChangeTokenSource<TOptions> implementations to enable cascade re-evaluation of options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2476.
Note: I considered doing that for
AuthenticationOptions(so that new authentication scheme forwarders could be automatically registered when options are reloaded) andHttpClientFactoryOptions(so that new actions are registered when reloadingOpenIddict*SystemNetHttpOptionsbut:AuthenticationOptions(or more precisely, it has no effect since the settings are directly extracted in the constructor and the class doesn't useIChangeTokento track changes).IOptionsChangeTokenSource<TOptions>.