Skip to content

Update tsconfig.json - add packages/contracts#1013

Open
qq7 wants to merge 5 commits into
masterfrom
qq7-patch-1
Open

Update tsconfig.json - add packages/contracts#1013
qq7 wants to merge 5 commits into
masterfrom
qq7-patch-1

Conversation

@qq7

@qq7 qq7 commented May 8, 2024

Copy link
Copy Markdown
Collaborator

without this line, running gsn deploy fails with Error: Cannot find module '@opengsn/contracts/types/ethers-contracts'
closes #1006

@qq7 qq7 requested a review from forshtat May 8, 2024 22:06
@forshtat

Copy link
Copy Markdown
Member

without this line, running gsn deploy fails with Error: Cannot find module '@opengsn/contracts/types/ethers-contracts' closes #1006

Unfortunately it appears that truffle is not able to install the solidity compiler any more, and given that truffle has been deprecated it is likely more things will break as well. So unless you can also fix this issue, merging this PR will not be useful until the migration to current frameworks is complete (#1012).

@qq7

qq7 commented May 13, 2024

Copy link
Copy Markdown
Collaborator Author

@forshtat

Unfortunately it appears that truffle is not able to install the solidity compiler any more

Ahh, I didn't check with 0.8.7... It compiled fine on my machine when I bumped solc version to 0.8.15. Let's give it a go on CircleCI...

@qq7

qq7 commented May 13, 2024

Copy link
Copy Markdown
Collaborator Author

This time it has worked. Might also make sense to bump solc version in paymasters package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

npx gsn relayer-register breaks on @opengsn/cli@3.0.0-beta.10

2 participants