Repository navigation
refactor(app-launcher): remove dead code and the no-op branch pull path - #465
Merged
Merged
Conversation
Drop the unused /status and deprecated /update routes with their GUI clients, the validators nobody imports, and an unused lodash import. docker.js now reads the deploy environment through config.
The catalog pins each app's commit, so the branch pull never updated anything. Remove the /pull management route, pullUpdates, the admin "check for updates" button and the updateAvailable field.
dfguerrerom
force-pushed
the
fix/app-launcher-pull-result
branch
from
October 30, 2026 10:14
202a8cd to
8a27093
Compare
dfguerrerom
marked this pull request as draft
October 30, 2026 12:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
app-launcher carried code nothing reached: the deprecated
/updateand unused/statusmanagement routes with their handlers and GUI API clients, thevalidateRepositoryandvalidatePathvalidators, and an unused lodash import.docker.jsnow reads the deploy environment throughconfig.jsinstead ofprocess.env.The branch pull path goes too. The catalog pins each app's commit, so
pullUpdatesnever updated anything and the admin "check for updates" button always answered "No updates available". This removes the/pullroute,pullUpdates,validateBranchName, the button, theupdateAvailablefield and its translations;cloneOrPullbecomescloneOrCheckout.Validation: the remaining management routes answer as before; GUI lint and tests pass.