Skip to content

refactor(app-launcher): remove dead code and the no-op branch pull path - #465

Merged
dfguerrerom merged 4 commits into
masterfrom
fix/app-launcher-pull-result
Nov 4, 2026
Merged

dfguerrerom merged 4 commits into
masterfrom
fix/app-launcher-pull-result

Conversation

@dfguerrerom

@dfguerrerom dfguerrerom commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

app-launcher carried code nothing reached: the deprecated /update and unused /status management routes with their handlers and GUI API clients, the validateRepository and validatePath validators, and an unused lodash import. docker.js now reads the deploy environment through config.js instead of process.env.

The branch pull path goes too. The catalog pins each app's commit, so pullUpdates never updated anything and the admin "check for updates" button always answered "No updates available". This removes the /pull route, pullUpdates, validateBranchName, the button, the updateAvailable field and its translations; cloneOrPull becomes cloneOrCheckout.

Validation: the remaining management routes answer as before; GUI lint and tests pass.

Drop the unused /status and deprecated /update routes with their GUI
clients, the validators nobody imports, and an unused lodash import.
docker.js now reads the deploy environment through config.
The catalog pins each app's commit, so the branch pull never updated
anything. Remove the /pull management route, pullUpdates, the admin
"check for updates" button and the updateAvailable field.
@dfguerrerom
dfguerrerom force-pushed the fix/app-launcher-pull-result branch from 202a8cd to 8a27093 Compare October 30, 2026 10:14
@dfguerrerom dfguerrerom changed the title fix(app-launcher): read the pull result's action and remove dead code refactor(app-launcher): remove dead code and the no-op branch pull path Oct 30, 2026
@dfguerrerom
dfguerrerom marked this pull request as draft October 30, 2026 12:42
@dfguerrerom
dfguerrerom marked this pull request as ready for review November 4, 2026 13:08
@dfguerrerom
dfguerrerom merged commit b4c998e into master Nov 4, 2026
23 checks passed
@dfguerrerom
dfguerrerom deleted the fix/app-launcher-pull-result branch November 4, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant