Repository navigation
fix: toast colours and AOI keyboard handling - #1122
Merged
Merged
Conversation
dfguerrerom
force-pushed
the
fix/toast-colours-aoi-keyboard
branch
from
November 16, 2026 13:33
01648fa to
72b7b9f
Compare
dfguerrerom
added a commit
that referenced
this pull request
Nov 16, 2026
dfguerrerom
added a commit
that referenced
this pull request
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toasts use their colours from before #1107 again: the SEPAL green for success in the light theme, and blue instead of the theme's light grey for info in the dark theme. A cancel toast is now an info toast with a cancel icon, not a pale tinted alert, and only the toast background is translucent.
In the AOI admin selects, typing highlights the first match, so Enter or Tab picks it, and Enter on a complete form runs Select AOI. AoiView also passed its column classes as a string, so they never applied; it now passes a list.
Validation: new tests for each change.
nox -s testpasses except the 3 known nox-onlytest_gdal_envfailures. Checked in a browser undersolara runand Voila, in light and dark.