Repository navigation
Escape user data in legacy data cleansing and map pages - #216
Merged
Merged
Conversation
- bootstrap-table 1.9 renders cell values as HTML: escape string values by default in all grids (data cleansing reports, query results...) - escape record keys, values and labels in the map info balloon and replace the inline onclick built from record keys with a handler - accept only survey languages as lang parameter of the Collect Earth balloon preview, it was written unescaped into the generated page
They have no JavaScript test setup, like the Collect Earth balloon assets.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Escapes user data in the legacy jQuery pages:
onclickbuilt from record keys is replaced by a bound handler.langparameter is written into the generated page, so only survey languages are accepted (default language otherwise).Checked in a running instance: a data query type label containing HTML is shown as text in the grid.