Skip to content

Escape user data in legacy data cleansing and map pages - #216

Merged
SteRiccio merged 3 commits into
masterfrom
fix/legacy-pages-xss
Nov 10, 2026
Merged

SteRiccio merged 3 commits into
masterfrom
fix/legacy-pages-xss

Conversation

@SteRiccio

Copy link
Copy Markdown
Member

Escapes user data in the legacy jQuery pages:

  • bootstrap-table 1.9 renders cell values as HTML. A default column formatter now escapes string values in every grid (data cleansing reports, query results, …). Columns with their own formatter are unchanged.
  • Map info balloon: record keys, values and labels are escaped; the inline onclick built from record keys is replaced by a bound handler.
  • Collect Earth balloon preview: the lang parameter is written into the generated page, so only survey languages are accepted (default language otherwise).

Checked in a running instance: a data query type label containing HTML is shown as text in the grid.

- bootstrap-table 1.9 renders cell values as HTML: escape string values
  by default in all grids (data cleansing reports, query results...)
- escape record keys, values and labels in the map info balloon and
  replace the inline onclick built from record keys with a handler
- accept only survey languages as lang parameter of the Collect Earth
  balloon preview, it was written unescaped into the generated page
They have no JavaScript test setup, like the Collect Earth balloon assets.
@sonarqubecloud

Copy link
Copy Markdown

@SteRiccio SteRiccio self-assigned this Nov 10, 2026
@SteRiccio
SteRiccio merged commit 21f502b into master Nov 10, 2026
3 checks passed
@SteRiccio
SteRiccio deleted the fix/legacy-pages-xss branch November 10, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant