Repository navigation
Reject record file names pointing outside the file repository - #214
Merged
Merged
Conversation
File attribute names come from record data (sent by the client or read from imported files) and were joined to the repository folder as-is, allowing '../' sequences to read or delete arbitrary files.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



File attribute values store a file name that comes from record data (sent by the client or read from imported files). It was joined to the record file repository folder as-is, so a name containing
../could point outside the repository (download, delete, backup).RecordFileManagernow resolves repository files through one method that accepts only plain file names (no path separators,.or..).Test: new
RecordFileManagerTest.