Repository navigation
Conversation
The deleted nodes are mapped with the node transform callback (manyOrNone ignored it: the callback is not one of its params); the record validation is checked with Validation.isValid(Record.getValidation(record)) (isObjValid takes an untyped object). The nodes / validation report select params not needed by all the callers are optional. The deprecated getSurveyDBSchema is replaced by Schemata.getSchemaSurvey. Functions without await are not async anymore.
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Converts the
recordserver module repositories to TypeScript (first part of the module: managers, jobs / update thread and service / API follow in separate PRs): record, node, node keys, file (DB, file system, S3 bucket) and validation report repositories.deleteNodesByUuidsmaps the deleted nodes with the node transform callback: it was passed tomanyOrNone, which has no such param, so it was ignored and the deleted nodes were returned with snake_case keys (no caller uses them yet). A no-op(row) => rowpassed tomanyOrNoneis removed as well.Validation.isValid(Record.getValidation(record)).ArenaRecordNode; params typed (NodeDefEntityfor root / ancestor defs,ArenaRecordNode[],ArenaValidation, record steps / cycles as strings).getSurveyDBSchemais replaced bySchemata.getSchemaSurvey; functions withoutawaitare notasyncanymore.Types of changes
How has this been tested
yarn typecheck: no errorsyarn test:unit: all passing except the 4 job tests that need a database (failing locally without PostgreSQL, same as on master)yarn build:server:prod: OKDo you consider this PR needs further testing?