Repository navigation
Update @openforis/arena-core to 2.24.0, remove the casts it makes unnecessary - #4764
Merged
Merged
Conversation
…ecessary DateFormats.datetimeExport (surveys list export), ChainProps.cycles (new chain) and the NodeDefEntityChildPosition minimum size props (node defs clone layout) are now declared by arena-core.
Contributor
|
This pull request is merged. |
…bage-6z89ib # Conflicts: # package.json # yarn.lock
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Updates
@openforis/arena-coreto 2.24.0 (openforis/arena-core#544), which declares types / values Arena used through casts:DateFormats.datetimeExportcore/dateUtilsformats.datetimeExportuses it, so the surveys list export passes it toconvertDatewithout a cast.
A new chain is created withChainProps.cyclesChainFactory.createInstance({ cycles })(no cast).
The node defs clone uses the layout position minimum sizes directly (the localNodeDefEntityChildPosition.minH/minW/maxHLayoutPositiontype and its cast are removed).A single arena-core version is resolved (
yarn dedupe @openforis/arena-core; arena-server requires^2.18.13).Types of changes
How has this been tested
yarn typecheck: no errorsyarn test:unit: all passing except the 4 job tests that need a database (failing locally without PostgreSQL, same as on master)yarn build:server:prod: OKDo you consider this PR needs further testing?