Repository navigation
External login providers (OpenID Connect): plan and implementation - #4748
Merged
Merged
Conversation
Contributor
|
This pull request is merged. |
…without a password
…gies, name icon buttons, plain text labels
Member
Author
|
The 88 SonarCloud issues were all in the login providers mockup HTML (73 Generated by Claude Code |
3 of 8 tasks
…ign-in methods in the profile - arena-server 2.8.17 (OpenID Connect sign-in) - admin API (system admins) over the arena-server provider service; user sign-in methods API with unlink - login page and invitation page buttons, 2FA step and errors after an external sign-in - Login providers system admin page (list, add, edit, test connection, test sign-in, delete) - Sign-in methods section in the user profile and edit view; password can be set when the user has none - e2e tests with a mock OpenID Connect provider
- user manual: 3.5 Signing in with Google, Microsoft or your organization's account; 14.4 Login providers - architecture and server requirements docs, .env.template - plan: implementation notes of the Arena side and follow-ups
…await in loop, prop types, output element)
Member
Author
|
Fixed the 6 SonarCloud issues in 18ce1ee:
|
…sets, clearer setup steps - client secret uses autocomplete new-password and the identifier field is no longer named id, so browsers don't fill the login email and password - Google and Microsoft presets suggest google / microsoft as identifier - per-type setup steps that name the fields to fill in (Connection section) and Save - redirect URI of a new provider is built by the server (public URL) instead of the browser origin
…ic (chips) - docs/login-providers: setup guides for Google, Microsoft, Keycloak and other OpenID Connect providers, linked from the provider form - Allowed email domains: radio buttons (all / only specific domains); specific domains are entered as chips and at least one is required - user manual (EN/FR/ES): allowed email domains, guide link and form screenshot updated
… link of hidden providers - the Preview login page button opened the login page, which redirects logged-in users to the app (the edit form already has a preview of the button) - a provider not shown on the login page is used with the sign-in start link (<public URL>/auth/oidc/<id>): the info of Show on the login page named a /guest/login?provider= link that doesn't exist - user manual (EN/FR/ES): login providers list and edit form screenshots updated
…er and direct link of hidden providers - What's new item for system admins (EN/FR/ES), with screenshots of the login page and of the Login providers page - changelog entry for the next release (2.14.0, not released yet: to be dated, or renumbered, at release) - user manual (EN/FR/ES): google / microsoft suggested as identifier, direct link of the providers not shown on the login page
…adable in the dialog)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Sign-in with external identity providers (Google, Microsoft, any OpenID Connect provider such as Keycloak, Okta or an institutional SSO), alongside email/password login. The server side is in arena-server 2.8.17 (openforis/arena-server#236).
Plan and mockup
docs/superpowers/plans/2026-11-17-oidc-authentication.md(design, access rules, security checklist, implementation notes and follow-ups) and the clickable admin UI mockup indocs/superpowers/mockups/2026-11-18-login-providers/.Login and invitation pages
System administration > Login providers (system admins only)
google/microsoftsuggested as identifier for the presets).AUTH_PROVIDERS_CONFIGare read-only.Sign-in methods in the profile and user edit view
Server
server/modules/authProvider/: admin API and sign-in methods API over the arena-serverAuthProviderService.{ key, params }with their status.Other changes
docs/architecture.md, external login setup indocs/server-requirements.mdand.env.template, setup guides for Google, Microsoft, Keycloak and other OpenID Connect providers indocs/login-providers/(linked from the provider form).openid-client,oauth4webapiandjoseare transformed, as other ESM-only dependencies already are.AUTH_PROVIDER_SECRET_ENCRYPTION_KEYfor the e2e tests.Types of changes
@openforis/arena-server2.8.17 (@openforis/arena-corestill resolves to a single version); new dev dependencyoauth2-mock-server.How has this been tested
yarn typecheckand ESLint (no errors) on the changed files.yarn test:uniton Node 24.22.3: 2279 tests passed.test/e2e/specs/externalLogin.spec.tsagainst a mock OpenID Connect provider (oauth2-mock-server): provider listed in the admin page, existing user signs in with the provider, unknown user refused, linked provider shown in the profile. It passes locally, together withlogin.spec.ts.Do you consider this PR needs further testing?
Sign-in with real Google, Microsoft and Keycloak clients in a deployment with
ARENA_PUBLIC_URLandAUTH_PROVIDER_SECRET_ENCRYPTION_KEYset.UI changes
New login buttons, invitation page buttons, System administration > Login providers page and Sign-in methods section; screenshots are in the manual sections below.
docs/user-manual/, English, French and Spanish) updated, or not neededNew sections 3.5 Signing in with Google, Microsoft or your organization's account and 14.4 Login providers, with screenshots, in the three languages.
Disclaimer
Follow-ups (listed in the plan): a recent-login check before a user sets their first password, a Sign-in method filter and column in the users list, identity links in the users backup export/import, and translations of the admin page into the other five languages.