Repository navigation
Conversation
…es `CompactSubGeometry` includes. Most users likely don't need "secondary UVs", for instance, and could save memory by omitting them. Others might want to add a custom 4-length attribute.
Without that, the clone will interpret all its data incorrectly.
This reduces duplicate code and allows activating custom attributes.
Methods can use this to alert other classes that they require certain custom attributes. These attributes will also automatically be tracked and deduplicated.
This version avoids unnecessary allocations, and can be chained.
Technically, the register only contains the first part of the matrix, and the next three registers contain the rest, but I didn't want to make the comment longer.
…vertex position.
This currently doesn't matter because compilers are never reused, but that could change someday.
This allows applying other materials and methods to the set, though these interactions are untested and not well supported. Per-segment colors are temporarily disabled, though `ColorMaterial` can be used to set a color globally. This also fixes some bugs with the line width. This means the lines are no longer twice as wide as `thickness` (though a temporary `-D away3d_double_line_width` flag exists to reverse this).
Instead of having to set the color of every segment, a single-color material can be used.
This can help avoid adding redundant methods to a material.
This also fixes compatibility with Haxe 4.1 and earlier.
player-03
marked this pull request as ready for review
October 4, 2026 02:20
Collaborator
Author
|
Here's the Lines sample in action. I updated the line thickness and used Lines.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows applying custom materials and/or effects to your line segments, and fixes some bugs related to line width. Previously, lines were always drawn at twice the requested width, and would get even wider if
stage.height > stage.width.The "Lines," "ParticleTrails," and "MouseInteraction" samples work as-is, albeit with thinner lines than before. ParticleTrails looks better now, IMO, but the others need updating to fix that.
This PR includes #66, which allows
CompactSubGeometryto include a vertex color attribute.