fix: drop superadmin entries from assignment list endpoint#345
fix: drop superadmin entries from assignment list endpoint#345mariajgrimaldi wants to merge 1 commit into
Conversation
|
Thanks for the pull request, @mariajgrimaldi! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
87a824c to
7ea290e
Compare
7126420 to
e98c1ef
Compare
Staff/superuser entries were fetched separately from role assignments, so org/scope/role filters did not apply to them. Drop them from this endpoint for now; the single-user endpoint still returns them. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
e98c1ef to
091b250
Compare
Description
Staff/superuser entries were fetched separately from role assignments in
AssignmentsAPIView, so org/scope/role filters did not apply to them. This PR removes them from the list endpoint entirely for now. The single-user endpoint (TeamMemberAssignmentsAPIView) still returns them.Follow-up: #347
Testing Instructions
GET /api/authz/v1/assignments/and verify nodjango.staffordjango.superuserentries appear.Merge checklist:
Check off if complete or not applicable: