Skip to content

fix: drop superadmin entries from assignment list endpoint#345

Draft
mariajgrimaldi wants to merge 1 commit into
mainfrom
MJG/filter-out-admins
Draft

fix: drop superadmin entries from assignment list endpoint#345
mariajgrimaldi wants to merge 1 commit into
mainfrom
MJG/filter-out-admins

Conversation

@mariajgrimaldi

@mariajgrimaldi mariajgrimaldi commented Jun 24, 2026

Copy link
Copy Markdown
Member

Description

Staff/superuser entries were fetched separately from role assignments in AssignmentsAPIView, so org/scope/role filters did not apply to them. This PR removes them from the list endpoint entirely for now. The single-user endpoint (TeamMemberAssignmentsAPIView) still returns them.

Follow-up: #347

Testing Instructions

  1. Log in as a staff/superuser.
  2. Call GET /api/authz/v1/assignments/ and verify no django.staff or django.superuser entries appear.
  3. Apply any org, scope, or role filter and verify the count reflects only role assignments.

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jun 24, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @mariajgrimaldi!

This repository is currently maintained by @openedx/committers-openedx-authz.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Jun 24, 2026
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/filter-out-admins branch 2 times, most recently from 87a824c to 7ea290e Compare June 24, 2026 12:53
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Jun 24, 2026
@mariajgrimaldi mariajgrimaldi changed the title fix: restrict superadmin entries to staff/superuser callers in assignments API fix: drop superadmin entries from assignment list endpoint Jun 29, 2026
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/filter-out-admins branch 2 times, most recently from 7126420 to e98c1ef Compare June 29, 2026 09:21
Staff/superuser entries were fetched separately from role assignments, so
org/scope/role filters did not apply to them. Drop them from this endpoint
for now; the single-user endpoint still returns them.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

3 participants