Render native add-component strip for generic container XBlocks by salman2013 · Pull Request #3058 · openedx/frontend-app-authoring

salman2013 · 2026-05-12T17:58:16Z

Description

Note: The changes in this PR is generated by Claude Sonet 4.6, reviewed by Salman. Based on the implementation plan suggested on the original ticket (#2620)

Details for the original bug can be found here: #2620

The backend (openedx-platform) dependent PR for this change: openedx/openedx-platform#38636

Settings

EDX_PLATFORM_REPOSITORY: https://github.com/openedx/openedx-platform.git
EDX_PLATFORM_VERSION: salman/fix-container-block

OPENEDX_EXTRA_PIP_REQUIREMENTS:
- xblock-problem-builder

openedx-webhooks · 2026-05-12T17:58:22Z

Thanks for the pull request, @salman2013!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov · 2026-05-12T18:21:08Z

Codecov Report

❌ Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.52%. Comparing base (0188698) to head (b37a010).
⚠️ Report is 5 commits behind head on master.

Files with missing lines	Patch %	Lines
src/course-unit/add-component/AddComponent.tsx	94.44%	1 Missing ⚠️
...rse-unit/add-component/add-component-btn/index.jsx	75.00%	1 Missing ⚠️
src/course-unit/hooks.tsx	50.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #3058    +/-   ##
========================================
  Coverage   95.52%   95.52%            
========================================
  Files        1393     1393            
  Lines       32969    33544   +575     
  Branches     7592     7899   +307     
========================================
+ Hits        31493    32043   +550     
- Misses       1408     1432    +24     
- Partials       68       69     +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kdmccormick · 2026-05-13T05:01:47Z

The general approach on both this PR and the openedx-platform PR look good to me!

When you're ready, can you make a sandbox for testing? You can make it on this PR, and use tutor configuration to point the backend at your openedx-platform branch:
https://github.com/open-craft/pr-sandbox-automation/tree/main/docs#1-tutor-configurations

salman2013 · 2026-05-13T08:34:12Z

@kdmccormick The sandbox has been created successfully if you could get a chance to take a look at it.
https://github.com/openedx/frontend-app-authoring/pull/3058/checks?check_run_id=75731943406

salman2013 · 2026-06-23T20:57:46Z

@bradenmacdonald Could you also take a look into this PR. thanks.

bradenmacdonald · 2026-06-25T20:41:15Z

@salman2013 Why are you closing and re-opening this PR so many times?

Do you not have the "re-run checks" button in the UI on this page ?

bradenmacdonald · 2026-06-25T21:33:11Z

 AddComponentButton.defaultProps = {
  beta: false,
+  disabled: false,
+  disabledReason: null,


defaultProps is deprecated - please don't add any new defaults to defaultProps. Instead, use ES6 function defaults and remove the whole defaultProps entirely.

bradenmacdonald · 2026-06-25T21:33:43Z

  onClick: PropTypes.func.isRequired,
  beta: PropTypes.bool,
+  disabled: PropTypes.bool,
+  disabledReason: PropTypes.string,


This is OK, but we prefer if you can convert this file to TypeScript and remove propTypes altogether while you're changing this file anyways.

bradenmacdonald · 2026-06-25T21:33:59Z

 ComponentModalView.defaultProps = {
  isRequestedModalView: false,
+  disabled: false,
+  disabledReason: null,


Same here: do not add defaultProps.

bradenmacdonald · 2026-06-25T21:34:45Z

 export interface AddComponentProps {
  isSplitTestType?: boolean;
  isUnitVerticalType?: boolean;
+  isGenericContainerType?: boolean;


This is kind of vague. Please add a /** JSDoc comment */ explaining what this parameter is for.

bradenmacdonald · 2026-06-25T21:38:11Z

                    isSplitTestType={isSplitTestType}
                    isUnitVerticalType={isUnitVerticalType}
                    isProblemBankType={isProblemBankType}
+                    isGenericContainerType={isGenericContainerType}


We should really just pass the containerType in, instead of isSplitTestType + isUnitVerticalType + isProblemBankType + isGenericContainerType. Having all these booleans is verbose and messy.

bradenmacdonald · 2026-06-25T21:39:25Z

  updateQueryPendingStatus,
 } from './data/slice';

 export const useCourseUnit = ({


Nit: this can be fixed in a separate PR, but if this hook/component is used for split test, problem bank, and many other things, it shouldn't be called "CourseUnit" and should be called "CourseComponentContainer" or something more generic.

chore: render native add-component strip for generic container XBlocks

5576870

openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels May 12, 2026

openedx-webhooks added this to Contributions May 12, 2026

github-project-automation Bot moved this to Needs Triage in Contributions May 12, 2026

salman2013 changed the title ~~chore: render native add-component strip for generic container XBlocks~~ Render native add-component strip for generic container XBlocks May 12, 2026

fix: formating issues fix

b37a010

salman2013 mentioned this pull request May 12, 2026

Fix Container Blocks in the New Unit Editor openedx/openedx-platform#38636

Draft

salman2013 added the create-sandbox open-craft-grove should create a sandbox environment from this PR label May 13, 2026

salman2013 closed this May 13, 2026

github-project-automation Bot moved this from Needs Triage to Done in Contributions May 13, 2026

salman2013 reopened this May 13, 2026

salman2013 marked this pull request as ready for review May 13, 2026 10:10

salman2013 mentioned this pull request May 13, 2026

Fix Container Blocks in the New Unit Editor #2620

Open

salman2013 requested review from farhan and kdmccormick May 13, 2026 10:28