Skip to content

fix: remove unnecessary call to fetch courses on course authoring page#1714

Draft
saadyousafarbi wants to merge 1 commit into
masterfrom
saad/remove-course-home-call
Draft

fix: remove unnecessary call to fetch courses on course authoring page#1714
saadyousafarbi wants to merge 1 commit into
masterfrom
saad/remove-course-home-call

Conversation

@saadyousafarbi

Copy link
Copy Markdown
Contributor

Description

Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per

Useful information to include:

  • Which edX user roles will this change impact? Common user roles are "Learner", "Course Author",
    "Developer", and "Operator".
  • Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).
  • Provide links to the description of corresponding configuration changes. Remember to correctly annotate these
    changes.

Supporting information

Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

Please provide detailed step-by-step instructions for testing this change.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.

@codecov

codecov Bot commented Mar 5, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.39%. Comparing base (26c919a) to head (f816705).
⚠️ Report is 622 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1714      +/-   ##
==========================================
- Coverage   93.39%   93.39%   -0.01%     
==========================================
  Files        1110     1110              
  Lines       22284    22282       -2     
  Branches     4811     4725      -86     
==========================================
- Hits        20812    20810       -2     
- Misses       1400     1407       +7     
+ Partials       72       65       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Arpit-Nakrani-Networked pushed a commit to Arpit-Nakrani-Networked/frontend-app-authoring that referenced this pull request Jul 13, 2025
* feat: base modifications to disable completion checks when flag enabled

* chore: started updating tests

* chore: udpated tests

* chore: added missing negative test

---------

Co-authored-by: Adolfo R. Brandes <adolfo@axim.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant