ci: fix manual review app deployment instructions

[bolinocroustibat]

Closes #807

[abulte]

I rather like the pattern with the PR number in the URL, and we've been using it for two years. Plus, this will cause mayhem with branch names like fix/xxx.

If we really want to avoid the PR number as input, we could try to get it from the GitHub API? I did it in reverse here https://github.com/opendatateam/udata-front-kit/pull/802/files#diff-3daa2cb95537798352dc8a58b25d016bdacee39718012369b677c0f04a99aa70R35.

Finally, we may not need to overoptimize the inputs in this workflow since #802 will let us deploy only with the site id.

[bolinocroustibat]

I rather like the pattern with the PR number in the URL, and we've been using it for two years. Plus, this will cause mayhem with branch names like fix/xxx.

If we really want to avoid the PR number as input, we could try to get it from the GitHub API? I did it in reverse here https://github.com/opendatateam/udata-front-kit/pull/802/files#diff-3daa2cb95537798352dc8a58b25d016bdacee39718012369b677c0f04a99aa70R35.

Finally, we may not need to overoptimize the inputs in this workflow since #802 will let us deploy only with the site id.

Sure, we can find a way to manage that properly from the PR number

[abulte]

This won't remove the branch from the input UI on GitHub, right? Feels weird to ignore a native parameter that works as designed... Like I said previously, this feels a bit over optimized and #802 will simplify the workflow anyway.

[bolinocroustibat]

This won't remove the branch from the input UI on GitHub, right? Feels weird to ignore a native parameter that works as designed... Like I said previously, this feels a bit over optimized and #802 will simplify the workflow anyway.

Yes it seems the branch selector in the input UI on GitHub is native and can't be removed.
From what I understood from your previous message I thought you were suggesting to keep the PR selector, sorry from misunderstanding.
So we want no PR input in the GUI, only the native branch one (I agree), but the PR number deduced from the branch? I would think we can deduce a branch from a PR number, but I wouldn't be sure about the opposite, as there can be several PRs from the same branch?

[abulte]

This won't remove the branch from the input UI on GitHub, right? Feels weird to ignore a native parameter that works as designed... Like I said previously, this feels a bit over optimized and #802 will simplify the workflow anyway.

Yes it seems the branch selector in the input UI on GitHub is native and can't be removed. From what I understood from your previous message I thought you were suggesting to keep the PR selector, sorry from misunderstanding. So we want no PR input in the GUI, only the native branch one (I agree), but the PR number deduced from the branch? I would think we can deduce a branch from a PR number, but I wouldn't be sure about the opposite, as there can be several PRs from the same branch?

To be clear, I think the current state is fine. It's a bit painful to input both branch and PR number but I can live with it, and anyway I'll use #802 when it's merged. Makes more sense anyway, since the comment "knows" on which PR we're working.

[abulte]

🙏