Cleaning up#506
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR cleans up the TypeScript-facing libOpenCOR WASM APIs by switching from index-based collection access (size()/get()) to standard iteration, and bumps package versions accordingly.
Changes:
- Update
IWasmIssuesand issue conversion logic to useIterable+for..of. - Update WASM
FileManager.filestyping and loops to useIterable+for..of. - Bump root and renderer package versions (including
libopencorVersion).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/renderer/src/libopencor/locLoggerApi.ts | Switch WASM issues handling from size/get to iterable iteration. |
| src/renderer/src/libopencor/locFileApi.ts | Switch WASM file manager files from size/get to iterable iteration. |
| src/renderer/package.json | Bump renderer package + libopencorVersion. |
| package.json | Bump root package version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…nCOR to version 0.20260529.0.
Note: externalizeDeps is enabled by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.