Add Remove Bulk API support for NextHopGroups and NextHopGroupMembers #630
Closed
tejatamboli02 wants to merge 2 commits into
Closed
Add Remove Bulk API support for NextHopGroups and NextHopGroupMembers #630tejatamboli02 wants to merge 2 commits into
tejatamboli02 wants to merge 2 commits into
Conversation
Contributor
|
/gcbrun |
Contributor
|
Can you pls update the title? Current title is not descriptive. |
tejatamboli02
force-pushed
the
fbr-flow
branch
from
af6d66c to
661da9f
Compare
Added implementation for RemoveNextHopGroups and RemoveNextHopGroupMembers on server side
tejatamboli02
force-pushed
the
fbr-flow
branch
from
661da9f to
6236a73
Compare
tejatamboli02
changed the title
Contributor
Author
Fixed it. |
sonikajindal
reviewed
Jan 7, 2026
| ttlMode := req.GetEncapTtlMode() | ||
| switch ttlMode { | ||
| case saipb.TunnelTtlMode_TUNNEL_TTL_MODE_UNIFORM_MODEL: // Copy the TTL from the inner IP header. | ||
| if ttlMode == saipb.TunnelTtlMode_TUNNEL_TTL_MODE_UNIFORM_MODEL { // Copy the TTL from the inner IP header. |
Contributor
There was a problem hiding this comment.
Do u need to rebase? This change already went in yesterday right?
sonikajindal
approved these changes
Jan 7, 2026
Contributor
|
/gcbrun |
Contributor
Author
|
Opened new separate pull request 631 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.