Build universal macOS release artifact#58
Conversation
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Codex review: needs maintainer review before merge. Reviewed June 27, 2026, 5:06 PM ET / 21:06 UTC. Summary Reproducibility: yes. for the source-level release packaging path: current main builds and zips one default-architecture macOS binary, matching the linked Intel Mac artifact failure. I did not rerun the shipped artifact on physical Intel macOS in this review. Review metrics: 2 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land this shared universal packaging path, or an equivalent maintainer-approved release-path fix, after maintainer review accepts the artifact proof and release automation risk; then let the linked Intel Mac issue close when the fix merges and ships. Do we have a high-confidence way to reproduce the issue? Yes for the source-level release packaging path: current main builds and zips one default-architecture macOS binary, matching the linked Intel Mac artifact failure. I did not rerun the shipped artifact on physical Intel macOS in this review. Is this the best way to solve the issue? Yes: the shared universal build, package, and check path is the narrow maintainable fix for the release artifact bug. The remaining question is release automation acceptance, not a different implementation direction. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning high; reviewed against 4e8643ff0ed9. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
@clawsweeper re-review |
Closes #57.
Builds the macOS release artifact through a shared universal binary packaging script so the Homebrew-consumed zip contains both arm64 and x86_64 slices. The release workflow now validates the packaged archive with lipo/file checks, and the notarization helper reuses the same universal build path.
Real behavior proof:
make macos-artifact; unzipdist/remindctl-macos.zip; runfile,lipo -info, andscripts/check-macos-artifact.sh dist/remindctl-macos.zipon the generated archive.remindctlbinary;filereportedMach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit executable x86_64] [arm64:Mach-O 64-bit executable arm64];lipo -inforeportedArchitectures in the fat file ... are: x86_64 arm64.scripts/check-macos-artifact.sh dist/remindctl-macos.zippassed.