Repository navigation
ci: audit the MCP production lockfile before npm release - #1930
mldangelo-oai wants to merge 14 commits into
Conversation
alandelong-oai
left a comment
There was a problem hiding this comment.
The audit implementation remains sound on this rebased head: both production lockfiles are checked, both reports remain visible after an audit failure, and CI and npm release validation receive the combined failure status.
The acknowledged rollout blocker remains. The live command exits 1: the SDK passes the high-severity threshold, while the MCP graph reports GHSA-27r3-jxmh-p828 through body-parser 2.3.0. The new-head hosted audit fails at the same step. Keep this draft until the dependency update makes both audits pass; merging this head would leave required CI and npm release validation failing.
Owner-level verification: 38 focused tests passed (410 assertions), plus all 13 routing/gate tests, frozen installs, build:ci, types, formatting and diff checks. No additional implementation finding or duplicate inline comment. The remaining hosted platform checks were still running when checked.
alandelong-oai
left a comment
There was a problem hiding this comment.
The audit implementation remains sound on 45ff8b0c, including the restored fixture import on the native-report stack. Both production lockfiles are checked, both reports remain visible after an audit failure, and CI and release validation receive the combined failure status.
The acknowledged rollout blocker remains: the live command and this head’s hosted audit fail on the MCP graph’s existing body-parser 2.3.0 advisory, GHSA-27r3-jxmh-p828. Keep this draft until the dependency update makes both hosted audits pass; required CI and npm release validation would otherwise fail.
Owner-level verification: 20 skeleton tests passed (217 assertions), including all audit failure scenarios; all 13 CI-selection tests, frozen installs, CI compilation, types, formatting, syntax and diff checks also passed. Local checks ran on Linux; the full SDK/native suite was not rerun. No new inline finding.
eaed09a to
21ec216
Compare
alandelong-oai
left a comment
There was a problem hiding this comment.
The direct workflow steps are sound on f8b7887c: each production lockfile is audited separately, the MCP report remains enabled after either SDK result, and either failure blocks required CI and npm release validation. This is a useful simplification of the earlier wrapper.
The acknowledged rollout blocker remains. The exact local commands and this head’s hosted audit pass the SDK audit and fail the MCP audit on body-parser 2.3.0 / GHSA-27r3-jxmh-p828. Keep this draft until the dependency update makes both hosted audits pass. No new inline finding.
Owner-level verification: all 19 skeleton tests (225 assertions), 21 CI selection/source checks, frozen installs, CI compilation, SDK/MCP types, package formatting and actionlint/ShellCheck passed. Verified the hosted merge tree matches the reviewed head. The full SDK/native suite and Socket-wrapped release commands were not rerun locally.
alandelong-oai
left a comment
There was a problem hiding this comment.
Re-reviewed c06224f1: both production lockfiles are selected explicitly, both audit reports remain available after an SDK audit failure, and either failure blocks CI and npm release validation. No new implementation findings.
The acknowledged rollout blocker remains. The exact local commands and this head’s hosted checks pass the SDK audit and fail the MCP audit on the existing body-parser advisory. Keep this draft until both audits pass; no duplicate inline finding.
Owner-level verification: 19 skeleton tests (225 assertions), 21 CI selection/source tests, workflow lint, and changed-file formatting passed. Verified the hosted merge tree matches the reviewed head and the failure reaches required CI. Full SDK/native suites and Socket-wrapped release commands were not rerun locally.
alandelong-oai
left a comment
There was a problem hiding this comment.
Reviewed 6dbe3fb0: the two production lockfiles are selected explicitly, the MCP audit still runs after an SDK audit failure, and either failure blocks CI and npm release validation. No new implementation findings.
The acknowledged rollout blocker remains: the exact local SDK command passes the high-severity threshold, while the MCP audit exits 1 on body-parser 2.3.0 / GHSA-27r3-jxmh-p828. Keep this draft until both audits pass.
Owner-level verification: 19 skeleton tests (225 assertions), 21 CI selection/gating/source tests, frozen installs, CI compilation, SDK/MCP types, formatting, and actionlint/ShellCheck passed. Full SDK/native suites and Socket-wrapped release commands were not rerun locally. No duplicate inline finding.
alandelong-oai
left a comment
There was a problem hiding this comment.
Reviewed b646a6889: both production lockfiles are selected explicitly, the MCP audit remains enabled after either SDK audit result, and either failure blocks CI and npm release validation. No new implementation findings.
The acknowledged rollout blocker remains. The exact local commands and this head’s hosted audit pass the SDK audit and fail the MCP audit on the existing body-parser advisory. Keep this draft until both audits pass; no duplicate inline finding.
Owner-level merge-safety verification: 19 skeleton tests (225 assertions), 21 CI selection/source tests, frozen installs, CI compilation, SDK/MCP types and formatting, actionlint/ShellCheck, and configured zizmor passed. Verified the hosted merge tree matches the reviewed head. Full SDK/native suites and Socket-wrapped release commands were not rerun locally.
alandelong-oai
left a comment
There was a problem hiding this comment.
Reviewed f522f78b: both production lockfiles remain selected explicitly, the MCP audit runs after either SDK audit result, and either failure blocks CI and npm release validation. No new implementation findings.
The acknowledged rollout blocker remains. The exact local commands and this head’s hosted audit pass the SDK audit and fail the MCP audit on the existing body-parser advisory. Keep this draft until both audits pass; no duplicate inline finding.
Fresh verification passed 19 skeleton tests (224 assertions), 22 CI selection/source tests, frozen installs, CI compilation, SDK/MCP types, formatting, actionlint/ShellCheck and configured zizmor. The hosted merge tree matches the reviewed head. Other hosted jobs were still running; full SDK/native suites and Socket-wrapped release commands were not rerun locally.
alandelong-oai
left a comment
There was a problem hiding this comment.
Both production lockfiles remain selected explicitly, the MCP audit runs after either SDK audit result, and either failure blocks CI and npm release validation. No new implementation findings.
The acknowledged rollout blocker remains on this head: the exact local SDK command passes the high-severity threshold, while the MCP audit exits 1 on the existing body-parser advisory. Keep this draft until both audits pass.
This owner-level merge-safety pass verified 18 skeleton tests (220 assertions), all 24 CI selection/source/release-guide tests, frozen SDK installation, changed-file formatting, configured actionlint/ShellCheck and zizmor, and diff checks. Full SDK/native suites and Socket-wrapped release commands were not rerun locally.
alandelong-oai
left a comment
There was a problem hiding this comment.
Reviewed 3f2a7d48: both production lockfiles are selected explicitly, the MCP audit runs after either SDK audit result, and either failure blocks CI and npm release validation. No new implementation findings.
The acknowledged rollout blocker remains. The exact local commands and this head’s hosted audit pass the SDK audit and fail the MCP audit on the existing body-parser advisory. Keep this draft until both audits pass.
This owner-level merge-safety pass verified 18 skeleton tests (219 assertions), 24 CI selection/source/release-guide tests, frozen installs, CI compilation, SDK/MCP types and formatting, actionlint/ShellCheck, and configured zizmor. The hosted merge tree matches the reviewed head. Full SDK/native suites and Socket-wrapped release commands were not rerun locally.
Summary
CI and npm release validation audit the bundled MCP app's production lockfile as well as the SDK's. Each audit reports its result and either failure blocks the job.
Changes
Run each command from its project directory and pin the lockfile there. The MCP audit still runs when the SDK audit fails; release validation runs both through Socket. The SDK's existing audit command and output remain compatible.
Testing
mainat7dcfe0d1, all 24 CI selection, source and release guide checks and all 18 SDK workflow tests (220 assertions) passed. The patch applied independently to the same tree.Risk and rollout
Keep this draft until both hosted audits pass. The body-parser advisory identifies 2.4.0 as the fix on this release line; its seven-day dependency cooldown ends October 29 at 11:40 UTC. Verify the version is available to the normal resolver before updating the lockfile.
Public disclosure review