Skip to content

Add support for ADL 2.4 at-coded node id's#660

Draft
joostholslag wants to merge 5 commits into
masterfrom
adl_2.4_support
Draft

Add support for ADL 2.4 at-coded node id's#660
joostholslag wants to merge 5 commits into
masterfrom
adl_2.4_support

Conversation

@joostholslag

@joostholslag joostholslag commented Feb 16, 2025

Copy link
Copy Markdown

Draft (to keep up to date on progresse)

  • [WIP] ADL++

  • [WIP] ADL++


ADL 2.4 support in Archie

* [WIP] ADL++

* [WIP] ADL++

---------

Co-authored-by: Jelte Zeilstra <jelte.zeilstra@nedap.com>
@codecov

codecov Bot commented Feb 16, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.28%. Comparing base (6021bdc) to head (73cb5e5).

Files with missing lines Patch % Lines
...dap/archie/adl14/ADL14ConversionConfiguration.java 71.42% 4 Missing ⚠️
...dap/archie/adl14/ADL14TermConstraintConverter.java 88.23% 0 Missing and 2 partials ⚠️
...a/com/nedap/archie/adl14/ADL14NodeIDConverter.java 91.66% 0 Missing and 1 partial ⚠️
...main/java/com/nedap/archie/aom/utils/AOMUtils.java 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #660      +/-   ##
============================================
+ Coverage     72.25%   72.28%   +0.02%     
- Complexity     7217     7233      +16     
============================================
  Files           680      680              
  Lines         23393    23419      +26     
  Branches       3791     3795       +4     
============================================
+ Hits          16903    16928      +25     
  Misses         4753     4753              
- Partials       1737     1738       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@borutjures

Copy link
Copy Markdown

@joostholslag What is the purpose of this PR? It includes the changes from #659 which were merged 2 days ago.

@joostholslag

Copy link
Copy Markdown
Author

That pr was merged into a branch that this pr now merges into main. I assume more changes will have to be done to have a single pr for adl2.4 changes to Archie.

@borutjures

Copy link
Copy Markdown

Thank you for pointing this out. I missed that #659 was merged into a branch. Can't wait to land these changes into main branch.

@joostholslag

Copy link
Copy Markdown
Author

@MattijsK would you be willing to list the other required changes in the PR description?

@joostholslag

Copy link
Copy Markdown
Author

This file needs updating too https://github.com/openEHR/archie/blob/master/base/src/main/java/com/nedap/archie/definitions/AdlCodeDefinitions.java

not sure it’s covered by the todo in the pr text.

VeraPrinsen and others added 3 commits April 16, 2026 10:29
* Be able to set adlVersion in the configuration:

* Add configuration to convert adl1.4 into adl2 at-coded

* Remake example archetypes

* Fix conversion of valueSets

* remove dutch comments

* requested changes

* Change NodeIdUtil codes to String

* Fix issues

* Fix issue that new nodes are created in specialisations

* Fix tests

* Revert gitignore change

* Update .gitignore

* Extract code to check code system and update documentation

* Update tests

* Update ADL14ToADL2Test.java

* Make tests better

* extract code that removed unnecessary codes

* add comment

* Update ADL14ToADL2Test.java

* Requested changes

* Update code after merge

* Fix test now that the order of terminology codes is normal again

* Update ArchetypeTerm.java

* Update ArchetypeTerm.java

* Update TerminologyRelation.java

* Update TerminologyRelation.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants