Removing extra word.#944
Merged
Merged
Conversation
calumbell
approved these changes
Jun 1, 2026
eepMoody
added a commit
that referenced
this pull request
Jun 6, 2026
* fixed parsing reaction conditions without parentheses (#842) * Fix spell data regressions and omissions (#844) * Fix spell data regressions from PR #842 and update newrelic API * add missing higher-leve options * add tests for duplicate or missing higher_level values * Add missing casting options for deepm and spells-that-dont-suck * fix freezing sphere being merged with freedom of movement * Convert distance fields to integer (#845) * Fix spell data regressions from PR #842 and update newrelic API * add missing higher-leve options * add tests for duplicate or missing higher_level values * Add missing casting options for deepm and spells-that-dont-suck * fix freezing sphere being merged with freedom of movement * convert ambiguously precise fields to integers * update test cases to reflect integers * update decimal speed fallbacks * fixed bugs in srd-2024 CreatureAction data (closes #847) (#849) * fixed markdown errors in Creature spellcasting traits/actions (#855) * updated srd-2014 dragon breath weapon recharge data (closes #848) (#853) * removed prepended asterisks from toh/tdcs FeatBenefit 'desc' fields (closes #851) (#852) * fixed bugs in srd-2024 spell markdown (closes #857) * updated monster conversion script to scrap input md for bonus actions and reactions * added missing srd-2024 creature reactions * removed Mithral and Adamantine Hide Armor from srd-2014 dataset (closes #829) * bugfix: added missing dash to bfrd mechanist starting equipment markdown * added 2024 champion subclass data to ClassFeatureItem.json * added srd-2024 College of Lore data to ClassFeatureItem.json * replaced casting_times of 'bonus_action' w/ 'bonus-action' as per model spec * wrote exclude_fields_mixin (and mvd mixins to own dir) * added ExcludeFieldsMixin to model viewsets * added missing srd-2024 dragon attack data to CreatureAttackAction * removed /manifest from url, updated test cases to reflect rmvl * rmv'd ManifestViewSet * removed ManifestSerializer * removed Manifest model * rmv'd manifest from v1 API schema * removed /version endpoint * Adding CrossReference model * Adding in some crossreference utilities. * Move logic into scripts/crossreference folder exclusively. Adding apply command. * Enhance CrossReference model by adding document field for denormalization and indexing. Update export command logic to simplify model checks. * Add CrossReference.json file for SRD 2024 with comprehensive cross-references for various game elements, enhancing data structure and accessibility. * Refactor cross-reference terminology for consistency across the codebase. * Implement crossreference handling in GameContentSerializer and add tests to verify crossreference inclusion/exclusion for various models. * Add source URL handling and crossreference methods to models and serializers - Introduced `get_source_url` utility to generate API URLs for source objects. - Enhanced `CrossReference` model with `reference_api_url` and `source_api_url` methods. - Updated `HasDescription` abstract model to include `get_crossreferences_to_from` method for structured crossreference data. - Modified `GameContentSerializer` to utilize the new crossreference structure. - Updated tests to verify crossreference inclusion and exclusion across various models. * Refactor URL generation for cross-references in API - Introduced `_get_basename_for_object` and `_build_object_url` utility functions to streamline URL generation for reference and source objects. - Updated `get_reference_url` and `get_source_url` to utilize the new utilities, improving code clarity and maintainability. - Enhanced handling for `Item` model to differentiate between magic items and regular items in URL generation. * Update .gitignore to include new report files - Added entries for `references_report.json` and `sources_report.json` to the .gitignore file to prevent tracking of temporary report files. * Refactor URL handling and enhance cross-reference functionality - Updated URL generation logic in `url_utils.py` to resolve nested models correctly, particularly for models with "Description" in their name. - Introduced `_resolve_to_parent_if_description` function to ensure URLs point to parent objects when applicable. - Modified `REFERENCE_MODEL_TO_BASENAME` mappings for improved consistency in URL generation. - Enhanced cross-reference identification logic in `core.py` to prevent duplicate references from the same source. - Updated `REFERENCE_MODEL_NAMES` to exclude models with "Description" in their name, streamlining reference handling. * Update CrossReference.json for SRD 2024 with new entries and primary key adjustments - Added multiple new cross-reference entries related to "Proficiency Bonus" and "Resistance" for various game elements. - Updated primary keys for existing entries to ensure uniqueness and consistency in the data structure. - Enhanced the overall cross-reference model to improve data accessibility and integrity. * Update CrossReference.json and core.py for SRD 2024 enhancements - Updated primary keys in CrossReference.json to ensure uniqueness for new entries. - Added context suggestions for "acid" damage type and "chain" related to "Chain Lightning" spell in core.py to improve cross-reference functionality. - Enhanced data structure and context handling for better accessibility and accuracy in game mechanics. * Enhance GameContentSerializer to manage crossreferences for root and list-item serializers * Add is_crossreference_source method to models and update GameContentSerializer * Refactor GameContentSerializer to improve handling of crossreferences for root and list-item serializers * Adjusted crossreference source handling in core.py and document.py * Update CrossReference model documentation and related comments for clarity * Add OpenAPI schema for crossreferences in GameContentSerializer * Refactor crossreference handling in HasDescription and GameContentSerializer * crossreferences were being returned on everything. Filtering down to the correct list. * Updating tests based on manual review of all responses. * Reports should not have been checked in. * Enhance blacklist loading in core.py to resolve relative paths against project root, ensuring correct loading regardless of current working directory. Also, add a new entry to the crossref_source_blacklist.txt. * added character creation rules from srd-2024 (#878) * Implement deterministic key generation for CrossReference model and update export functionality to support natural foreign keys. * Add handling for ambiguous reference names in crossreference matching * Blacklisting abilities for crossref match for now. * Deduplicate crossreferences before creation to prevent duplicate keys and enhance reference matching. * Adding in 2014 crossreference. * Add new crossreferences for spellcasting and range items in SRD 2014 * Fixing tests and slight adjustments to export. * Refactor crossreference handling in models and serializers. Just "To" now, no longer from. * Remove "from" crossreferences from various approved JSON response files and update related viewsets to reflect changes in crossreference handling. * Added filter on monsters for environments (#884) * Removed item/magicitem lookup. * rewrote crossreferences. * Regenned Crossreferences with new logic. * Updated item viewset registration with a basename and added extra kwargs for URL resolution in item serializers. * Limiting crossreferences to only those within the tests. * fixed typo in srd-2024 Adult Green Dragon spellcasting action (#891) * [BUGFIX] Fixed data errors on `/v2/rulesets/srd_combat-sequence` (#893) * removed references to <srd:opportunity-attacks> in all open5e data * fixed ruleset/srd_combat-sequence blockquote markdown * added missing ClassFeatureItem for Fighter two extra attacks action (#895) * removed server/vector_index.pkl from repo (#883) * removed leading slashes on Image file_urls (#886) * [CI/CD] Upgrade Github Action versions to Node 24 compatable versions (#901) * updated checkout github action to v6 * updated setup-python gh action to v6 * updated upload-artifact gh action to v6 * updated build-push-action gh action to v7 * Feature: split V2 Item model into Item and MagicItem models (#889) * split v2 Item endpoint into Item and MagicItem endpoints * removed vector_index from commit * rmv'd accidently commited DDT config * updated buggy test case, see issue #888 * [BUGFIX] `GameContentSerializer` now inherits from `ModelSerializer` (#899) * GameContentSerializer now inherits from ModelSerializer * removed 'url' from GameContent Meta->fields prop * updated v2 tests to reflect removal of URL from many responses * fixed failing test * rmvd url field from MagicItemSerializer * Bugfix: seperated mixed up V1/V2 endpoints (#890) * updated api/urls.py to stop v1 and v2 endpoints getting mixed up * updated v1 tests to check against endpoints behind /v1/ subroute * [BUGFIX] Fixed EagerLoadingMixin early return error (#898) * fixed bug in EagerLoadingMixin conditional logic, closes #897 * fixed EagerLoadingMixin missing base case, added docstring * Bump django from 5.2.1 to 5.2.12 (#904) Bumps [django](https://github.com/django/django) from 5.2.1 to 5.2.12. - [Commits](django/django@5.2.1...5.2.12) --- updated-dependencies: - dependency-name: django dependency-version: 5.2.12 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump requests from 2.32.3 to 2.33.0 (#905) Bumps [requests](https://github.com/psf/requests) from 2.32.3 to 2.33.0. - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.32.3...v2.33.0) --- updated-dependencies: - dependency-name: requests dependency-version: 2.33.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump urllib3 from 2.4.0 to 2.6.3 (#906) Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.4.0 to 2.6.3. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@2.4.0...2.6.3) --- updated-dependencies: - dependency-name: urllib3 dependency-version: 2.6.3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump django from 5.2.12 to 5.2.13 (#908) Bumps [django](https://github.com/django/django) from 5.2.12 to 5.2.13. - [Commits](django/django@5.2.12...5.2.13) --- updated-dependencies: - dependency-name: django dependency-version: 5.2.13 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fixed bug in srd-2014 skeleton resistances/immunities (#907) * fixed markdown bugs in srd-2014 brass dragons (#912) * updated srd-2024 goliath giant ancestry markdown: added missing list bullets (#909) * consolidated CRs into single 'challenge_rating' field (#910) * Update with v2 info Added an announcement about the launch of API V2 and the maintenance status of V1, including migration instructions. * updated ExcludeFieldsMixin to support excluding nested fields * updated EagerLoadingMixin to work correctly with new nested excludes * improved comments on mixins * Bump pytest from 8.3.5 to 9.0.3 (#913) Bumps [pytest](https://github.com/pytest-dev/pytest) from 8.3.5 to 9.0.3. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest@8.3.5...9.0.3) --- updated-dependencies: - dependency-name: pytest dependency-version: 9.0.3 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump django from 5.2.13 to 5.2.14 (#916) Bumps [django](https://github.com/django/django) from 5.2.13 to 5.2.14. - [Commits](django/django@5.2.13...5.2.14) --- updated-dependencies: - dependency-name: django dependency-version: 5.2.14 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump urllib3 from 2.4.0 to 2.7.0 (#917) Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.4.0 to 2.7.0. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@2.4.0...2.7.0) --- updated-dependencies: - dependency-name: urllib3 dependency-version: 2.7.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fixed search bug (non-existant extra fields) * Draft pyproject with a few improvements over pipfile. * Added (aspirational) version. * Checking in lockfile. * Fixing env issues. * Adjusting secret key settings to work better for devs. * Removing .env, to avoid confusion. * Removing deprecated files. * Keeping on 3.11 for now. * Updating readme with uv switchover. * Fixing PR validation to switch over. * Fixing based on a failed cache pruning. * Two step build. * Adjust models to support more strict types. * Fixing spells * Fixing conflicting migration heads. * Pulling it up to date. * Made cache clear dependent on the other workflow. (#929) * fixed bugs in srd-2014 mastiff statblock * updated tests to reflect updated data returned by API * 718 technical debt align model field names and serializer names (#932) * Updating field names. * Data updated to match new fields. * Bump idna from 3.10 to 3.15 (#928) Bumps [idna](https://github.com/kjd/idna) from 3.10 to 3.15. - [Release notes](https://github.com/kjd/idna/releases) - [Changelog](https://github.com/kjd/idna/blob/master/HISTORY.md) - [Commits](kjd/idna@v3.10...v3.15) --- updated-dependencies: - dependency-name: idna dependency-version: '3.15' dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fixing agents.md as well. * 937 bug creature data mismatches in srd52 (#942) * Simple Edits to the 5 cited creatures. * Adding in Giant Fly. * Removing extra word. (#944) * 938 bug spell data mismatches in srd52 (#943) * Fixing noted VSM problems. * Fixing some discovered data errors. * Fixing some A spells. * Adding some better spell descriptions. * Fixing appended outcomes. * fix: renumber migration 0075 to 0080 to follow staging chain Staging has migrations 0075-0079 that didn't exist when this branch was cut. Renumber to avoid leaf node conflict. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: correct casting_time values for find-familiar and forbiddance '1 hour' and '10 minutes' must be '1hour' and '10minutes' to match the model's SPELL_CASTING_TIME_CHOICES enum. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * [BUGFIX] Creature model now inherits from HasDescription (#949) * 926 migrate beta deploy to use ghcr instead of docker hub 2 (#945) * Adding distinct github image deployable. * Creating a dockerignore to avoid files too big. * Adjusting dockerfile to only consume the minimal fields. * Bonus quicksetup fix, for speedup. Migrations should be made at build time. * Adding in a sqlite change or two for speedup. * hotfix: build and deploy workflow * hotfix: docker config path issue * hotfix: update Dockerfile and workflows to unblock process * hotfix: issue with shared item view * fix values erroneously changed during merge --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Blake Watson <blake@blakewatson.com> Co-authored-by: calum <47755775+calumbell@users.noreply.github.com> Co-authored-by: calumbell <calumabell@googlemail.com> Co-authored-by: August Johnson <august@fastmail.com> Co-authored-by: August Johnson <augustjohnson@users.noreply.github.com> Co-authored-by: Steven Noto <stevennoto@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just removing a bad title. Key is fine.