Skip to content

fix Self to Impl type replacer #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mise42 merged 2 commits into from
May 12, 2025
Merged

fix Self to Impl type replacer #72

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1499bad
fix `Self` to `Impl` type replacer
mise42 May 12, 2025
2b4c23e
remove eprintln
mise42 May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions pvq-extension/procedural/src/extension_decl/expand/metadata.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ pub fn expand_metadata(def: &Def) -> TokenStream2 {
syn::ReturnType::Default => quote!(#scale_info::meta_type::<()>()),
syn::ReturnType::Type(_, ty) => {
let mut ty = ty.clone();
// Replace Self::AssociatedType with Impl::AssociatedType
replacer.visit_type_mut(&mut ty);
quote!(#scale_info::meta_type::<#ty>())
}
Expand Down Expand Up @@ -73,12 +74,12 @@ pub fn expand_metadata(def: &Def) -> TokenStream2 {
}
}

// Convert `Self::AssociatedType` to `Impl::AssociatedType`
// Replace `Self` with `Impl` in the type path
struct AssociatedTypeReplacer;
impl syn::visit_mut::VisitMut for AssociatedTypeReplacer {
fn visit_path_mut(&mut self, path: &mut syn::Path) {
if path.segments.len() == 2 && path.segments[0].ident == "Self" {
path.segments[0].ident = syn::Ident::new("Impl", path.segments[0].ident.span());
fn visit_ident_mut(&mut self, ident: &mut syn::Ident) {
if ident == "Self" {
*ident = syn::Ident::new("Impl", ident.span());
}
}
}
Loading