Two fixes for PR dashboard workflow#7
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes two issues discovered while deploying and running the reusable PR dashboard workflows. The first ensures the caller job grants the GitHub Actions token permissions that the called reusable workflow's jobs require, since reusable-workflow job permissions are capped by the caller. The second makes the Netlify dispatcher environment configuration idempotent by deleting the managed variables before re-setting them with the correct production/functions context and scope.
Changes:
- Add a
permissionsblock to therun-repo-dashboardcaller job matching the exact union of permissions used by the jobs inpull-request-dashboard-repo.yml. - Unset the managed Netlify variables (
OTELBOT_SHARED_WORKFLOWS_APP_ID,OTELBOT_SHARED_WORKFLOWS_PRIVATE_KEY_BASE64) with--force || truebefore re-setting them, clearing stale context/scope metadata that caused the Netlify CLI to fail.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/pull-request-dashboard.yml |
Grants the caller job the permissions union (actions: read, checks: read, contents: write, issues: write, pull-requests: read) needed by the called reusable workflow jobs. |
.github/workflows/deploy-pull-request-dashboard-webhook.yml |
Recreates the dispatcher env vars by unsetting them before re-setting production/functions scope, avoiding CLI failures from outdated context/scope metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
maryliag
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two PR dashboard workflow issues found while deploying/running the reusable dashboard workflows.
The dashboard caller now grants the permissions that the called reusable workflow jobs need, so GitHub Actions validation no longer caps nested jobs at
contents: read.The Netlify webhook deploy now recreates its managed dispatcher environment variables before setting production/function scope, avoiding the Netlify CLI failure when existing variables have outdated context or scope metadata.