Skip to content

update to client id#10

Merged
trask merged 1 commit into
open-telemetry:mainfrom
maryliag:update-id
Jun 25, 2026
Merged

update to client id#10
trask merged 1 commit into
open-telemetry:mainfrom
maryliag:update-id

Conversation

@maryliag

Copy link
Copy Markdown
Contributor

App ID is deprecated (and it giving warnings during the execution of those workflows).
Update to the recommended client ID.

I already added the env variable to the settings

Copilot AI review requested due to automatic review settings June 25, 2026 18:39
@maryliag maryliag requested review from a team and trask as code owners June 25, 2026 18:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the pull-request-dashboard workflows from the deprecated app-id input of actions/create-github-app-token to the recommended client-id input, switching the referenced GitHub Actions variable from PR_DASHBOARD_APP_ID to PR_DASHBOARD_CLIENT_ID. This removes deprecation warnings during workflow execution. The author notes the new variable has already been added to repository settings.

Changes:

  • Replaced app-id: ${{ vars.PR_DASHBOARD_APP_ID }} with client-id: ${{ vars.PR_DASHBOARD_CLIENT_ID }} across all token-creation steps.
  • Updated documentation (README and WEBHOOK_SETUP) to reference the new client ID variable.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
.github/workflows/pull-request-dashboard.yml Switched token step to client-id/PR_DASHBOARD_CLIENT_ID.
.github/workflows/pull-request-dashboard-repo.yml Updated all four token steps and an explanatory comment to use the client ID variable.
.github/scripts/pull-request-dashboard/WEBHOOK_SETUP.md Updated setup instructions to reference PR_DASHBOARD_CLIENT_ID.
.github/scripts/pull-request-dashboard/README.md Updated documentation reference to the client ID variable.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@trask trask merged commit dadedc9 into open-telemetry:main Jun 25, 2026
5 checks passed
@maryliag maryliag deleted the update-id branch June 25, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants