Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
package io.opentelemetry.api.incubator.config;

import com.fasterxml.jackson.databind.ObjectMapper;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
import java.util.function.Function;
Expand All @@ -18,39 +17,6 @@
*/
public class InstrumentationConfigUtil {

/**
* Return a map representation of the peer service map entries in {@code
* .instrumentation.general.peer.service_mapping}, or null if none is configured.
*
* @throws DeclarativeConfigException if an unexpected type is encountered accessing the property
* @deprecated Peer service mapping was removed from the general instrumentation configuration
* schema. See <a
* href="https://github.com/open-telemetry/opentelemetry-configuration/pull/526">opentelemetry-configuration#526</a>.
*/
@Deprecated
@Nullable
public static Map<String, String> peerServiceMapping(ConfigProvider configProvider) {
List<DeclarativeConfigProperties> serviceMappingList =
getOrNull(
configProvider,
config -> config.getStructuredList("service_mapping"),
"general",
"peer");
if (serviceMappingList == null) {
return null;
}
Map<String, String> serviceMapping = new LinkedHashMap<>();
serviceMappingList.forEach(
entry -> {
String peer = entry.getString("peer");
String service = entry.getString("service");
if (peer != null && service != null) {
serviceMapping.put(peer, service);
}
});
return serviceMapping.isEmpty() ? null : serviceMapping;
}

/**
* Return {@code .instrumentation.general.http.client.request_captured_headers}, or null if none
* is configured.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,17 +65,6 @@ private static ConfigProvider toConfigProvider(String configYaml) {
new ByteArrayInputStream(configYaml.getBytes(StandardCharsets.UTF_8))));
}

@SuppressWarnings("deprecation") // testing deprecated method
@Test
void peerServiceMapping() {
assertThat(InstrumentationConfigUtil.peerServiceMapping(kitchenSinkConfigProvider))
.isEqualTo(ImmutableMap.of("1.2.3.4", "FooService", "2.3.4.5", "BarService"));
assertThat(InstrumentationConfigUtil.peerServiceMapping(emptyInstrumentationConfigProvider))
.isNull();
assertThat(InstrumentationConfigUtil.peerServiceMapping(emptyGeneralConfigProvider)).isNull();
assertThat(InstrumentationConfigUtil.peerServiceMapping(emptyHttpConfigProvider)).isNull();
}

@Test
void httpClientRequestCapturedHeaders() {
assertThat(
Expand Down
Loading