Adjust declarative config pojo toString, hashCode, equals to match autovalue#8526
Merged
jack-berg merged 2 commits intoJun 24, 2026
Merged
Conversation
21629bf to
8da139e
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8526 +/- ##
=============================================
+ Coverage 78.51% 90.94% +12.42%
- Complexity 8601 10208 +1607
=============================================
Files 1013 1013
Lines 29150 27166 -1984
Branches 3632 3181 -451
=============================================
+ Hits 22887 24705 +1818
+ Misses 5420 1734 -3686
+ Partials 843 727 -116 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jaydeluca
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve lingering TODOs from #8408
This has a number of benefits:
@SuppressWarnings({"NullAway", "rawtypes", "BoxedPrimitiveEquality"})To make sure the adjusted equals / hashcode implementations are correct, I've added ModelEqualsHasCodeTest. This uses reflection to detect all the model classes, then uses equalsverifier to assert correctness of equals and has code.