Skip to content

Fix typo in ApiUsageLogger warning message#8485

Merged
jack-berg merged 1 commit into
open-telemetry:mainfrom
thswlsqls:fix/apiusagelogger-warning-typo
Jun 22, 2026
Merged

Fix typo in ApiUsageLogger warning message#8485
jack-berg merged 1 commit into
open-telemetry:mainfrom
thswlsqls:fix/apiusagelogger-warning-typo

Conversation

@thswlsqls

@thswlsqls thswlsqls commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Description

  • ApiUsageLogger.logUsageIssue emits a one-time WARNING, visible under default logging, reading "Stacktraces are includes to identify the offending call site" — "are includes" is ungrammatical.
  • Changed "are includes" to "are included", matching the same class Javadoc, which already phrases it correctly ("includes a Throwable").

Testing done

  • ./gradlew :common:check — full check (test + spotlessCheck + ErrorProne/NullAway + jApiCmp) BUILD SUCCESSFUL; existing ApiUsageLoggerTest confirms no regression.
  • String-literal change only: no docs/apidiffs diff and no CHANGELOG.md entry (not a user-facing config/feature/default change).

@linux-foundation-easycla

linux-foundation-easycla Bot commented Jun 19, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: thswlsqls / name: Eunbin Son (cb6f508)

@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.76%. Comparing base (824334c) to head (cb6f508).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8485      +/-   ##
============================================
- Coverage     78.77%   78.76%   -0.01%     
+ Complexity     8579     8578       -1     
============================================
  Files          1009     1009              
  Lines         28993    28993              
  Branches       3599     3599              
============================================
- Hits          22839    22837       -2     
- Misses         5311     5312       +1     
- Partials        843      844       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thswlsqls thswlsqls force-pushed the fix/apiusagelogger-warning-typo branch from da89e3d to cb6f508 Compare June 19, 2026 23:52
@thswlsqls thswlsqls marked this pull request as ready for review June 20, 2026 00:11
@thswlsqls thswlsqls requested a review from a team as a code owner June 20, 2026 00:11
@thswlsqls

Copy link
Copy Markdown
Contributor Author

/easycla

@jack-berg jack-berg merged commit 846d7d8 into open-telemetry:main Jun 22, 2026
29 checks passed
@otelbot

otelbot Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution @thswlsqls! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants