Fix incorrect Javadoc in DeclarativeConfigProperties#8484
Conversation
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8484 +/- ##
=========================================
Coverage 78.77% 78.77%
Complexity 8579 8579
=========================================
Files 1009 1009
Lines 28993 28993
Branches 3599 3599
=========================================
Hits 22839 22839
Misses 5311 5311
Partials 843 843 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/easycla |
jack-berg
left a comment
There was a problem hiding this comment.
Thanks!
FYI - I noticed you've opened a lot of PRs and issues. Just scanning over a few, they seem like good PRs: small in scope and useful. Still, it will take some time to get through them.
In the future, try to limit the number of open PRs you have open at any one time. Drive those to completion, then open another batch. 🙂
|
Thank you for your contribution @thswlsqls! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
Summary
getScalarList(name, scalarType, defaultValue)summary claimed non-string entries are converted to a string, but they are removed (along with empty values) when they do not map toscalarType.getStructured(name, defaultValue)summary said "list of" but the method returns a single mapping.getScalarList(name, scalarType),getStructured(name)); filtering happens inYamlDeclarativeConfigProperties#getScalarListvia.filter(Objects::nonNull)(sdk-extensions/declarative-config).Testing done
./gradlew :api:incubator:checkpassed.