Skip to content

Assert single-arg Logger.isEnabled overload in shared default logger test#8483

Merged
jack-berg merged 1 commit into
open-telemetry:mainfrom
thswlsqls:test/default-logger-isenabled-overload
Jun 22, 2026
Merged

Assert single-arg Logger.isEnabled overload in shared default logger test#8483
jack-berg merged 1 commit into
open-telemetry:mainfrom
thswlsqls:test/default-logger-isenabled-overload

Conversation

@thswlsqls

Copy link
Copy Markdown
Contributor

Summary

  • Logger has two stable overloads (since 1.61.0): isEnabled(Severity, Context) and isEnabled(Severity).
  • The shared base AbstractDefaultLoggerTest#defaultIsEnabled asserted only the 2-arg overload, so the api/all DefaultLogger 1-arg path was never exercised by any concrete test.
  • Add a 1-arg assertion to the base, matching the sibling api/incubator ExtendedDefaultLoggerTest which already asserts both overloads.
  • 1-arg overload introduced in Stabilize enabled api #8200 (Stabilize enabled api).

Testing done

  • ./gradlew :api:testing-internal:check passed (compile/spotless/errorprone; no concrete tests run there).
  • ./gradlew :api:all:test --tests "...DefaultLoggerTest" passed.
  • ./gradlew :api:incubator:test --tests "...ExtendedDefaultLoggerTest" passed.
  • Green before and after (coverage fill, not a behavior change). No public API change (no apidiff), no user-facing change (no CHANGELOG).

@linux-foundation-easycla

linux-foundation-easycla Bot commented Jun 19, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: thswlsqls / name: Eunbin Son (27a5b6d)

@thswlsqls thswlsqls marked this pull request as ready for review June 19, 2026 22:58
@thswlsqls thswlsqls requested a review from a team as a code owner June 19, 2026 22:58
@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.77%. Comparing base (824334c) to head (27a5b6d).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8483   +/-   ##
=========================================
  Coverage     78.77%   78.77%           
  Complexity     8579     8579           
=========================================
  Files          1009     1009           
  Lines         28993    28993           
  Branches       3599     3599           
=========================================
  Hits          22839    22839           
  Misses         5311     5311           
  Partials        843      843           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thswlsqls

Copy link
Copy Markdown
Contributor Author

/easycla

@jack-berg jack-berg merged commit 27319a4 into open-telemetry:main Jun 22, 2026
29 checks passed
@otelbot

otelbot Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution @thswlsqls! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants