Recommend agent_disconnect for plain HTTP transport#353
Open
Krishnachaitanyakc wants to merge 2 commits into
Open
Recommend agent_disconnect for plain HTTP transport#353Krishnachaitanyakc wants to merge 2 commits into
Krishnachaitanyakc wants to merge 2 commits into
Conversation
Update the Plain HTTP Transport section under Closing Connection to recommend (SHOULD) that HTTP clients include agent_disconnect in the last AgentToServer message on shutdown or when switching to new connection settings. This makes disconnect signalling consistent across WebSocket and plain HTTP transports and lets the Server immediately mark the Agent as disconnected rather than waiting for missed polling intervals. The server-side cleanup heuristic is retained as a fallback for ungraceful terminations (kill -9, etc.). Fixes open-telemetry#303
andykellr
previously requested changes
Jun 8, 2026
andykellr
left a comment
andykellr
left a comment
Contributor
There was a problem hiding this comment.
The language looks good, but can we make the agent_disconnect text a link to the field? Similar to instance_uid earlier in the spec.
tigrannajaryan
approved these changes
Jun 8, 2026
michel-laterman
approved these changes
Jun 9, 2026
Author
|
@andykellr can you review this? |
RassK
approved these changes
Jun 30, 2026
Member
|
@andykellr PTAL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the Plain HTTP Transport section under "Closing Connection" to recommend (SHOULD) that HTTP clients include
agent_disconnectin the last AgentToServer message on shutdown or when switching to new connection settings. This makes disconnect signalling consistent across WebSocket and plain HTTP transports.The server-side cleanup heuristic is retained as a fallback for ungraceful terminations.
A corresponding implementation change will be needed in opamp-go.
Fixes #303