Add GoToZone task-sequence event#136
Open
chart-singapore wants to merge 1 commit into
Open
Conversation
Signed-off-by: kjchee <keai_jiang_chee@cgh.com.sg>
This was referenced Apr 17, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New feature implementation
Implemented feature
This is part of an 8-repo Simple GoToZone feature. Tracked in Stage A of open-rmf/rmf#726.
Adds
GoToZonetormf_task_sequence::events— a task-level description that constructs aGoToPlaceactivity model over all zone internal vertices, wrapped in aZoneGuardModelfor bidding protection (prevent bidding from the robot already in the target zone). This is the task-planner-side entry point for zone tasks.Implementation description
GoToZone::DescriptionFactory:
GoToZone::Description::make(zone_name, modifiers), wheremodifiersisstd::optional<Modifiers>(defaultstd::nullopt). TheModifiersstruct carriesgroup_hint,orientation_hint, andpreferred_waypoints.make_model()— looks up the zone viaGraph::find_known_zone, collects waypoint indices for every internal vertex resolvable viagraph.find_waypoint(name), builds aGoToPlace::Description::make_for_one_of(goals)activity model, and wraps it inZoneGuardModel. Returnsnullptrif the zone is unknown, if every internal-vertex name fails to resolve to a waypoint, or if the innerGoToPlacemodel fails to build.generate_header()— produces the task header (category, description, duration).ZoneGuardModelWraps an inner
Activity::ConstModelPtr, purpose is to overrideestimate_finish(). For each candidate robot: if the robot's current waypoint is already one of the zone's internal-vertex waypoints, returnsstd::nullopt(purpose: excluding that robot from bidding on this zone task while keeping it available for every other task type).This guard works at the
estimate_finishlevel (per-robot) rather than atmake_model(per-task) because the per-candidate robot state is only available on eachestimate_finishcall.GenAI Use
We follow OSRA's policy on GenAI tools