Fix RunHostTest console execution and prevent duplicate sysinfo colle…#958
Merged
Merged
Conversation
9584f16 to
1c66230
Compare
…ction This commit addresses multiple issues in the RunHostTest execution flow: 1. Fixed console prompt mismatch in OpTestUtil.try_command() - Use pre-built term_obj.expect_prompt instead of rebuilding - Ensures consistency between terminal PS1 and expect pattern - Resolves command hangs caused by prompt pattern mismatch 2. Added use_direct_ssh parameter to OpTestSSH.run_command() - Allows console-based execution for session persistence - Maintains working directory between command executions - Default True for backward compatibility 3. Updated RunHostTest to use console-based execution - Set use_direct_ssh=False for all run_command() calls - Skip empty lines and comments in command files - Ensures cd commands persist across executions 4. Fixed false PETITBOOT state detection in OpTestSystem - Added console=1 parameter to host_run_command() - Prevents unnecessary system reboots during tests 5. Prevented duplicate OS sysinfo collection in OpTestHMC - Added sysinfo_collected flag to track collection state - Check flag before collecting in set_system() - Eliminates duplicate sysinfo output and improves performance These changes restore the original console-based execution behavior while maintaining compatibility with the SSH migration. Signed-off-by: Praveen K Pandey <praveen@linux.ibm.com>
1c66230 to
7c86f3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ction
This commit addresses multiple issues in the RunHostTest execution flow:
Fixed console prompt mismatch in OpTestUtil.try_command()
Added use_direct_ssh parameter to OpTestSSH.run_command()
Updated RunHostTest to use console-based execution
Fixed false PETITBOOT state detection in OpTestSystem
Prevented duplicate OS sysinfo collection in OpTestHMC
These changes restore the original console-based execution behavior while maintaining compatibility with the SSH migration.