OpTestKernelDump.py: Test crashkernel with memory offset parameter.#956
Closed
shirishaganta1 wants to merge 1 commit into
Closed
OpTestKernelDump.py: Test crashkernel with memory offset parameter.#956shirishaganta1 wants to merge 1 commit into
shirishaganta1 wants to merge 1 commit into
Conversation
| updated.append(new_arg) | ||
|
|
||
| return " ".join(updated) | ||
|
|
Collaborator
There was a problem hiding this comment.
seems me to many blank lines in b/w can you please take care of this
Contributor
Author
There was a problem hiding this comment.
seems me to many blank lines in b/w can you please take care of this
sure will take care that
Appends offset to existing crashkernel value and triggers crash Signed-off-by: Shirisha G <shirisha@linux.ibm.com>
shirishaganta1
force-pushed
the
offset-crashkernel
branch
from
1e0b315 to
6943802
Compare
Collaborator
|
@shirishaganta1 can you please run against the latest code and post the logs? |
Contributor
Author
|
@PraveenPenguin addressed all the above suggested changes.. due to some issue in my local op-test repo I have cloned it again and sent the new PR can you please check and merge it .. once you merge the below PR then I will close this PR #970 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Appends offset to existing crashkernel value and triggers crash