Generate datapackage metadata explicitly instead of inferring it#472
Open
Bachibouzouk wants to merge 6 commits into
Open
Generate datapackage metadata explicitly instead of inferring it#472Bachibouzouk wants to merge 6 commits into
Bachibouzouk wants to merge 6 commits into
Conversation
NB: this could also be simply hardcoded for the field or update the valuetype_list.csv file
Bachibouzouk
changed the title
paulapreuss
reviewed
May 12, 2026
Comment on lines
+233
to
+237
| if isinstance(value, int): | ||
| return "integer" | ||
|
|
||
| if isinstance(value, float): | ||
| return "number" |
There was a problem hiding this comment.
Could there be an issue where it will falsely label a float as an int field, e.g. if the parsed value is 0? Or should it be fine?
|
Just out of curiosity, what is the big difference between this method of inferring the datapackage vs. what was done in |
|
Seems like the build test is failing due to the most recent changes to |
Author
yes this is just a missing package |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
infer_metadata_from_datafromoemof.datapackagewas slowing down the generation of the datapackage. Instead I propose to generate the information contained within thedatapackage.jsondirectly. This results in much lower waiting time before the simulation is sent to the simulation server. It also allows us to not worry about generating the datapackage on the fly to process the results