Nuscene and truckscenes Radar compatibility#1769
Open
MatteGombia wants to merge 3 commits into
Open
Conversation
Rearranged import statements and updated __all__ to include CustomDataset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I worked on using point pillars on radar. I've changed the code to support nuscene's radar and truckscene both single radar or fusing multiple radar. Truckscene's code is convertible to Lidar with just a few changes in the code so supporting it may be good addition.
I would suggest to create a new branch for radar detection because more people are getting interested into radar detection. Or, alternatively, making it modular with some parameters in the config.
I don't think this pull request is acceptable in this state as it's not modular and to change what sensors you want, you need to change it directly in the code. However, it's a solid start and it's a way to show the growing interest in it