Migrated ContractDetails and ODCSModal by Rohit0301 · Pull Request #29013 · open-metadata/OpenMetadata

Rohit0301 · 2026-06-12T15:01:26Z

Describe your changes:

Fixes #

I worked on ... because ...

Type of change:

High-level design:

N/A — small change.

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Not applicable.

Checklist:

I have read the CONTRIBUTING document.
My PR title is Fixes <issue-number>: <short explanation>
My PR is linked to a GitHub issue via Fixes #<issue-number> above.
I have commented on my code, particularly in hard-to-understand areas.
For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
For UI changes: I attached a screen recording and/or screenshots above.
I have added tests (unit / integration / Playwright as applicable) and listed them above.

Summary by Gitar

UI Migration:
- Migrated ContractDetail and ODCSImportModal components from @mui/material and antd to @openmetadata/ui-core-components.
- Refactored styles to use Tailwind utility classes and updated component props to align with the new library standards.
Component logic updates:
- Updated ODCSImportModal file upload handling by replacing custom drag-and-drop logic with FileUploadDropZone.
- Optimized state management and event handlers for better integration with the core component library.
Testing updates:
- Added extensive mocks for the new UI components in ContractDetail.test.tsx and ODCSImportModal.test.tsx to accommodate the library migration.
- Cleaned up redundant MUI-specific test mocks and updated existing test cases to support the new component structure.

_{This will update automatically on new commits.}

github-actions · 2026-06-12T15:23:16Z

Jest test Coverage

UI tests summary

Lines	Statements	Branches	Functions
	62.42% (67011/107351)	43.91% (37089/84456)	45.78% (11459/25027)

github-actions · 2026-06-12T23:37:05Z

🔴 Playwright Results — 1 failure(s), 12 flaky

✅ 4291 passed · ❌ 1 failed · 🟡 12 flaky · ⏭️ 88 skipped

Shard	Passed	Failed	Flaky	Skipped
✅ Shard 1	301	0	0	4
🟡 Shard 2	811	0	1	9
🟡 Shard 3	807	0	5	8
🔴 Shard 4	846	1	3	12
🟡 Shard 5	733	0	1	47
🟡 Shard 6	793	0	2	8

Genuine Failures (failed on all attempts)

❌ Pages/DataContractInheritance.spec.ts › Delete Asset Contract - Falls back to showing inherited contract from Data Product (shard 4)

Error: �[2mexpect(�[22m�[31mlocator�[39m�[2m).�[22mtoBeVisible�[2m(�[22m�[2m)�[22m failed

Locator: locator('.ant-modal-title')
Expected: visible
Timeout: 15000ms
Error: element(s) not found

Call log:
�[2m  - Expect "toBeVisible" with timeout 15000ms�[22m
�[2m  - waiting for locator('.ant-modal-title')�[22m

🟡 12 flaky test(s) (passed on retry)

Features/Glossary/GlossaryAdvancedOperations.spec.ts › should create term with related terms (shard 2, 1 retry)
Features/KnowledgeCenterList.spec.ts › Knowledge Center List - Verify Recently Viewed widget (shard 3, 1 retry)
Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 2 retries)
Features/Table.spec.ts › Table pagination with sorting should works (shard 3, 1 retry)
Features/Table.spec.ts › should show dbt tab if only path is present (shard 3, 1 retry)
Features/Tasks/TaskNavigation.spec.ts › navigating to /table/TASK-XXXXX should show 404 (invalid URL pattern) (shard 3, 1 retry)
Flow/PersonaFlow.spec.ts › Set default persona for team should work properly (shard 4, 1 retry)
Pages/CustomProperties.spec.ts › Email (shard 4, 1 retry)
Pages/DataContracts.spec.ts › Create Data Contract and validate for Store Procedure (shard 4, 1 retry)
Pages/ExplorePageRightPanel_KnowledgeCenter.spec.ts › Should remove user owner for knowledgeCenter (shard 5, 1 retry)
Pages/Lineage/DataAssetLineage.spec.ts › Column lineage for searchIndex -> table (shard 6, 1 retry)
Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)

📦 Download artifacts

How to debug locally

# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

sonarqubecloud · 2026-06-13T19:36:41Z

Quality Gate passed for 'open-metadata-ui'

Issues
1491 New issues
0 Accepted issues

Measures
26 Security Hotspots
0.0% Coverage on New Code
3.4% Duplication on New Code

See analysis details on SonarQube Cloud

gitar-bot · 2026-06-14T07:02:10Z

+      <DeleteModal
+        entityTitle={contract?.name ?? ''}
+        message={t('message.are-you-sure-you-want-to-delete-this-entity', {
+          entity: t('label.contract'),
+        })}
+        open={isDeleteModalVisible}
+        onCancel={() => setIsDeleteModalVisible(false)}
        onDelete={handleContractDeleteConfirm}
      />


💡 Edge Case: DeleteModal not passed isDeleting; confirm allows double-click

ContractTab now uses the generic DeleteModal, which exposes an optional isDeleting prop to disable/show loading on the confirm button. handleContractDeleteConfirm is async (it awaits deleteContractById) but no loading state is tracked and isDeleting is not passed to the modal. During the in-flight delete the confirm button stays enabled, so a user can click it multiple times and fire several deleteContractById calls. The previous DeleteWidgetModal managed its own in-flight state, so this is a behavioral regression introduced by the migration. Consider adding an isDeleting state, setting it around the await, and passing isDeleting={isDeleting} to DeleteModal.

_{Was this helpful? React with 👍 / 👎}

gitar-bot · 2026-06-14T07:02:22Z

Code Review 👍 Approved with suggestions 1 resolved / 2 findings

Migrates ContractDetails and ODCSModal components to use OpenMetadata core components and Tailwind styling. Consider passing the isDeleting prop to DeleteModal in ContractTab to prevent duplicate form submissions.

💡 Edge Case: DeleteModal not passed isDeleting; confirm allows double-click

📄 openmetadata-ui/src/main/resources/ui/src/components/DataContract/ContractTab/ContractTab.tsx:121-135 📄 openmetadata-ui/src/main/resources/ui/src/components/DataContract/ContractTab/ContractTab.tsx:201-209

ContractTab now uses the generic DeleteModal, which exposes an optional isDeleting prop to disable/show loading on the confirm button. handleContractDeleteConfirm is async (it awaits deleteContractById) but no loading state is tracked and isDeleting is not passed to the modal. During the in-flight delete the confirm button stays enabled, so a user can click it multiple times and fire several deleteContractById calls. The previous DeleteWidgetModal managed its own in-flight state, so this is a behavioral regression introduced by the migration. Consider adding an isDeleting state, setting it around the await, and passing isDeleting={isDeleting} to DeleteModal.

✅ 1 resolved

✅ Edge Case: JSON contract uploads no longer accepted after migration

📄 openmetadata-ui/src/main/resources/ui/src/components/DataContract/ODCSImportModal/ODCSImportModal.component.tsx:1159-1167
The old implementation accepted .yaml, .yml and .json files for drag-and-drop import (validExtensions = ['.yaml', '.yml', '.json']). The new FileUploadDropZone is configured with accept=".yaml,.yml" and the library filters files against accept before calling onDropFiles, so JSON files are now silently rejected. If JSON contract import was a supported workflow, this is a functional regression. If dropping JSON support is intentional (the hint text now says "supports-yaml-format"), this can be ignored — otherwise add .json back to accept.

🤖 Prompt for agents

Code Review: Migrates ContractDetails and ODCSModal components to use OpenMetadata core components and Tailwind styling. Consider passing the `isDeleting` prop to `DeleteModal` in `ContractTab` to prevent duplicate form submissions.

1. 💡 Edge Case: DeleteModal not passed isDeleting; confirm allows double-click
   Files: openmetadata-ui/src/main/resources/ui/src/components/DataContract/ContractTab/ContractTab.tsx:121-135, openmetadata-ui/src/main/resources/ui/src/components/DataContract/ContractTab/ContractTab.tsx:201-209

   `ContractTab` now uses the generic `DeleteModal`, which exposes an optional `isDeleting` prop to disable/show loading on the confirm button. `handleContractDeleteConfirm` is async (it awaits `deleteContractById`) but no loading state is tracked and `isDeleting` is not passed to the modal. During the in-flight delete the confirm button stays enabled, so a user can click it multiple times and fire several `deleteContractById` calls. The previous `DeleteWidgetModal` managed its own in-flight state, so this is a behavioral regression introduced by the migration. Consider adding an `isDeleting` state, setting it around the await, and passing `isDeleting={isDeleting}` to `DeleteModal`.

Options

Display: compact → Showing less information.

Comment with these commands to change:

`Compact`
`gitar display:verbose`

_{Was this helpful? React with 👍 / 👎 | Gitar}

github-actions · 2026-06-14T07:05:22Z

❌ UI Checkstyle Failed

❌ Playwright — ESLint + Prettier + Organise Imports

One or more Playwright test files have linting or formatting issues.

Affected files

openmetadata-ui/src/main/resources/ui/playwright/utils/dataContracts.ts

Fix locally (fast — only checks files changed in this branch):

make ui-checkstyle-changed

Migrated ContractDetails and ODCSModal

d9f3ff3

Rohit0301 self-assigned this Jun 12, 2026

Rohit0301 requested a review from a team as a code owner June 12, 2026 15:01

Rohit0301 added safe to test Add this label to run secure Github workflows on PRs skip-pr-checks Bypass PR metadata validation check labels Jun 12, 2026

Merge branch 'main' into data-contract-mui-migration

d3ce46c

gitar-bot Bot reviewed Jun 12, 2026

View reviewed changes

Comment thread .../main/resources/ui/src/components/DataContract/ODCSImportModal/ODCSImportModal.component.tsx

Rohit0301 temporarily deployed to test June 12, 2026 15:16 — with GitHub Actions Inactive

Rohit0301 had a problem deploying to test June 12, 2026 15:16 — with GitHub Actions Error

Rohit0301 temporarily deployed to test June 12, 2026 15:16 — with GitHub Actions Inactive

lint fix

fa4e740

Rohit0301 had a problem deploying to test June 12, 2026 17:17 — with GitHub Actions Error

remove unused classes

2050505

Rohit0301 temporarily deployed to test June 12, 2026 17:36 — with GitHub Actions Inactive

Rohit0301 had a problem deploying to test June 12, 2026 17:36 — with GitHub Actions Failure

Rohit0301 had a problem deploying to test June 12, 2026 17:36 — with GitHub Actions Error

Rohit0301 temporarily deployed to test June 12, 2026 17:36 — with GitHub Actions Inactive

playwright test fix

555aefe

Rohit0301 temporarily deployed to test June 13, 2026 12:14 — with GitHub Actions Inactive

Rohit0301 had a problem deploying to test June 13, 2026 12:14 — with GitHub Actions Failure

Rohit0301 temporarily deployed to test June 13, 2026 12:14 — with GitHub Actions Inactive

Rohit0301 had a problem deploying to test June 13, 2026 12:14 — with GitHub Actions Failure

Rohit0301 added 2 commits June 14, 2026 00:33

playwright test fix

7f8867a

lint fix

2210da8

Rohit0301 temporarily deployed to test June 13, 2026 19:21 — with GitHub Actions Inactive

fix minor issues

e085cf0

gitar-bot Bot reviewed Jun 14, 2026

View reviewed changes

Rohit0301 had a problem deploying to test June 14, 2026 07:12 — with GitHub Actions Failure

Rohit0301 temporarily deployed to test June 14, 2026 07:12 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrated ContractDetails and ODCSModal#29013

Migrated ContractDetails and ODCSModal#29013
Rohit0301 wants to merge 8 commits into
mainfrom
data-contract-mui-migration

Rohit0301 commented Jun 12, 2026 •

edited by gitar-bot Bot

Loading

Uh oh!

Uh oh!

github-actions Bot commented Jun 12, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 12, 2026 •

edited

Loading

Uh oh!

sonarqubecloud Bot commented Jun 13, 2026

Uh oh!

gitar-bot Bot Jun 14, 2026

Uh oh!

gitar-bot Bot commented Jun 14, 2026

Uh oh!

github-actions Bot commented Jun 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Rohit0301 commented Jun 12, 2026 • edited by gitar-bot Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your changes:

Type of change:

High-level design:

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Checklist:

Summary by Gitar

Uh oh!

Uh oh!

github-actions Bot commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Jest test Coverage

UI tests summary

Uh oh!

github-actions Bot commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔴 Playwright Results — 1 failure(s), 12 flaky

Genuine Failures (failed on all attempts)

Uh oh!

sonarqubecloud Bot commented Jun 13, 2026

Quality Gate passed for 'open-metadata-ui'

Uh oh!

gitar-bot Bot Jun 14, 2026

Choose a reason for hiding this comment

Uh oh!

gitar-bot Bot commented Jun 14, 2026

Uh oh!

github-actions Bot commented Jun 14, 2026

❌ UI Checkstyle Failed

❌ Playwright — ESLint + Prettier + Organise Imports

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Rohit0301 commented Jun 12, 2026 •

edited by gitar-bot Bot

Loading

github-actions Bot commented Jun 12, 2026 •

edited

Loading

github-actions Bot commented Jun 12, 2026 •

edited

Loading