External LLM endpoint usage improvements + fixes#1166
Merged
Conversation
3 tasks
Improve/shorten/fix Helm variable names:
- Consistent Helm variable naming: LLM_SERVICE/LLM_SERVER -> LLM_SERVER
- Drop misleading/redundant _IP suffix: LLM_SERVER_HOST_IP -> LLM_SERVER_HOST
(Helm variables do not need to duplicate naming problems in OPEA applications.)
Add:
- Examples on using OPEA KubeAI installation as external LLM
- LLM_SERVER_PORT setting to everywhere LLM_SERVER_HOST is set
- Comment that NGIX needs to be disabled if UI/data-prep is disabled [1]
- Missing HF_TOKEN settings to external LLM usage examples
- Missing Ollama disabling
[2] Otherwise Helm fails to parse NGINX template file. Helm would
fail also on "if .Values.data-prep.enabled" in that file, due to
'-' in the component name, so best seemed just to add comment
about the dependency.
Fixes: c977012
Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
Merged
3 tasks
lianhao
approved these changes
Jul 21, 2025
poussa
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve/shorten/fix Helm variable names [1]:
Add:
See also PR #1167 for more general external inferencing support.
[1] Helm variables do not need to duplicate naming problems in OPEA applications: opea-project/GenAIExamples#2143.
Issues
Fixes incorrect external LLM variable name in CodeGen value file, missing HF_TOKENs in its README, and missing Ollama disabling in ChatQnA values file, that were added in PR #993.
Type of change
Whether this breaks anything depends on whether something already depends on these values, but it's better to improve them before they get to release.
Dependencies
n/aTests
TODO.