Fix build fail for EdgeCraftRAG.#2218
Merged
Merged
Conversation
Signed-off-by: ZePan110 <ze.pan@intel.com>
Dependency Review✅ No vulnerabilities or license issues found.Scanned Files
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a build failure for the EdgeCraftRAG component by downgrading the llama-index version and improves CI workflow coverage by adding requirements files to the image size check trigger.
- Downgrade llama-index from version 0.12.41 to 0.12.36 to resolve build compatibility issues
- Expand CI workflow triggers to include requirements file changes for better build validation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| EdgeCraftRAG/edgecraftrag/requirements.txt | Downgrades llama-index version to fix build failure |
| .github/workflows/pr-image-size.yml | Adds requirements files to workflow triggers while excluding one_click_deploy directory |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: ZePan110 <ze.pan@intel.com>
chensuyue
approved these changes
Aug 22, 2025
Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: ZePan110 <ze.pan@intel.com>
Collaborator
Author
|
HybridRAG is known issue #2222 |
Signed-off-by: ZePan110 <ze.pan@intel.com>
…IExamples into ze-opt/image-s
Signed-off-by: chensuyue <suyue.chen@intel.com>
chensuyue
approved these changes
Aug 27, 2025
lvliang-intel
approved these changes
Aug 27, 2025
cogniware-devops
pushed a commit
to Cogniware-Inc/GenAIExamples
that referenced
this pull request
Dec 19, 2025
Signed-off-by: ZePan110 <ze.pan@intel.com> Signed-off-by: chensuyue <suyue.chen@intel.com> Co-authored-by: chensuyue <suyue.chen@intel.com> Signed-off-by: cogniware-devops <ambarish.desai@cogniware.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix build fail for EdgeCraftRAG.
Enhance Check Docker Image Size Change workflow
Fix Inconsistent image names
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.