Skip to content

Fix build fail for EdgeCraftRAG.#2218

Merged
ZePan110 merged 10 commits into
mainfrom
ze-opt/image-s
Aug 27, 2025
Merged

Fix build fail for EdgeCraftRAG.#2218
ZePan110 merged 10 commits into
mainfrom
ze-opt/image-s

Conversation

@ZePan110

@ZePan110 ZePan110 commented Aug 22, 2025

Copy link
Copy Markdown
Collaborator

Description

Fix build fail for EdgeCraftRAG.
Enhance Check Docker Image Size Change workflow
Fix Inconsistent image names

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Copilot AI review requested due to automatic review settings August 22, 2025 03:09
@github-actions

github-actions Bot commented Aug 22, 2025

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

  • EdgeCraftRAG/edgecraftrag/requirements.txt

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a build failure for the EdgeCraftRAG component by downgrading the llama-index version and improves CI workflow coverage by adding requirements files to the image size check trigger.

  • Downgrade llama-index from version 0.12.41 to 0.12.36 to resolve build compatibility issues
  • Expand CI workflow triggers to include requirements file changes for better build validation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
EdgeCraftRAG/edgecraftrag/requirements.txt Downgrades llama-index version to fix build failure
.github/workflows/pr-image-size.yml Adds requirements files to workflow triggers while excluding one_click_deploy directory

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread .github/workflows/pr-image-size.yml Outdated
Signed-off-by: ZePan110 <ze.pan@intel.com>
@ZePan110 ZePan110 changed the title Add requirments to test scope and Fix build fail for EdgeCraftRAG. Fix build fail for EdgeCraftRAG. Aug 22, 2025
Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: ZePan110 <ze.pan@intel.com>
@ZePan110

ZePan110 commented Aug 22, 2025

Copy link
Copy Markdown
Collaborator Author

HybridRAG is known issue #2222

ZePan110 and others added 3 commits August 22, 2025 17:19
Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: chensuyue <suyue.chen@intel.com>
@ZePan110 ZePan110 merged commit 0eabdbf into main Aug 27, 2025
24 of 25 checks passed
@ZePan110 ZePan110 deleted the ze-opt/image-s branch August 27, 2025 01:31
cogniware-devops pushed a commit to Cogniware-Inc/GenAIExamples that referenced this pull request Dec 19, 2025
Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: chensuyue <suyue.chen@intel.com>
Co-authored-by: chensuyue <suyue.chen@intel.com>
Signed-off-by: cogniware-devops <ambarish.desai@cogniware.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants