Refactor API response to use top-level 'data' attribute for consistency#524
Open
Alsrory wants to merge 1 commit into
Open
Refactor API response to use top-level 'data' attribute for consistency#524Alsrory wants to merge 1 commit into
Alsrory wants to merge 1 commit into
Conversation
arukompas
requested changes
Jun 11, 2026
Author
|
Thanks for the feedback @arukompas, I'm on it.
في الخميس، ١١ يونيو ٢٠٢٦، ٠٩:٣١ Arunas Skirius ***@***.***>
كتب:
… ***@***.**** requested changes on this pull request.
1. Missing test coverage for the change
2. UI needs to be backwards compatible, as publishing updated UI
assets is optional.
3. Formatting is out of place
—
Reply to this email directly, view it on GitHub
<#524?email_source=notifications&email_token=ANL2QMMF6IREMDI55YKAFX347JG4XA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBXGQZDONZZHEZ2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-4474277993>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANL2QMKSQEO6VQBH5V7V63L47JG4XAVCNFSNUABFKJSXA33TNF2G64TZHM2TENBYHA3DSNJVHNEXG43VMU5TINRSGU4TCNRYGIYKC5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/ANL2QMNGH3ZCRLTIHJL4KGT47JG4XA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBXGQZDONZZHEZ2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/ANL2QMI5ZHRZPIQFAI2TJ7D47JG4XA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBXGQZDONZZHEZ2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the API response structure to use a top-level data attribute for the folders list.
Reason: This ensures consistency with standard API patterns and provides a clean namespace for future metadata (e.g., meta, links) without causing breaking changes or frontend parsing issues.
Changes: Updated FoldersController to wrap the resource collection, and adjusted the frontend axios response handler to parse data.data.
I have verified the changes locally, and the data is correctly received and parsed by the frontend.