Skip to content

refactor(connector): rename org header to x-oo-organization-name#279

Merged
BlackHole1 merged 1 commit into
mainfrom
rename
Jun 13, 2026
Merged

refactor(connector): rename org header to x-oo-organization-name#279
BlackHole1 merged 1 commit into
mainfrom
rename

Conversation

@BlackHole1

Copy link
Copy Markdown
Member

The organization identity request header was renamed from
x-oo-organization to x-oo-organization-name to match the server-side
contract. This is a header-name-only change; identity resolution,
telemetry, and the user-facing CLI contract are unaffected.

Signed-off-by: Kevin Cui bh@bugs.cc

The organization identity request header was renamed from
x-oo-organization to x-oo-organization-name to match the server-side
contract. This is a header-name-only change; identity resolution,
telemetry, and the user-facing CLI contract are unaffected.

Signed-off-by: Kevin Cui <bh@bugs.cc>
@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6939743b-ffc8-4339-9ba9-02dc01727cab

📥 Commits

Reviewing files that changed from the base of the PR and between 097fed3 and 504260c.

📒 Files selected for processing (4)
  • src/application/commands/connector/identity.test.ts
  • src/application/commands/connector/identity.ts
  • src/application/commands/connector/index.cli.test.ts
  • src/application/commands/connector/shared.test.ts

Summary by CodeRabbit

  • Bug Fixes
    • Updated organization identity header name in connector communications to ensure accurate organization identification across all connector operations.

Walkthrough

This PR renames the HTTP header key for organization identity in connector requests from x-oo-organization to x-oo-organization-name. The change updates the implementation in connectorIdentityHeaders to emit the organization identity under the new header key when identity.organization is set, while preserving empty headers for personal or undefined identity. All test assertions across the identity unit tests, CLI connector tests, and shared helper tests are updated to match the new header key across multiple scenarios including --organization, --org, default organization configuration, and --personal override cases.

Possibly related PRs

  • oomol-lab/oo-cli#274: Introduces organization identity header support in oo connector run command; this PR updates the header key contract from the original naming to the standardized x-oo-organization-name format.
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required format (): and accurately summarizes the main change: renaming the organization header to x-oo-organization-name across all connector-related files.
Description check ✅ Passed The description is directly related to the changeset, clearly explaining that the organization identity request header was renamed from x-oo-organization to x-oo-organization-name to match server-side contract.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch rename

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.


Comment @coderabbitai help to get the list of available commands and usage tips.

@BlackHole1 BlackHole1 merged commit 732fddd into main Jun 13, 2026
6 checks passed
@BlackHole1 BlackHole1 deleted the rename branch June 13, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant