feat(update): disable real updates in make run dev builds#12
Conversation
A `make run` build is always versioned 0.0.0-development, so every update check against the shipped production feed would "find" the newest stable release and could download and install it over the build under test. Sparkle is therefore never started in a bare dev build: no scheduled check fires and the production feed is never contacted. A manual "Check for Updates…" stays available but surfaces a "disabled in development" notice instead. The update lab (`make update-test-*`) is the one exception: it redirects the feed to a loopback server via LOCKIME_UPDATE_FEED, so the presence of that env var distinguishes the lab from a plain run and keeps its real download/install flow working. All new code is under #if DEBUG, leaving release builds unchanged. Signed-off-by: Kevin Cui <bh@bugs.cc>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Summary by CodeRabbit
WalkthroughThis PR adds development-build update isolation: when the 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Comment |
A
make runbuild is always versioned 0.0.0-development, so every update check against the shipped production feed would "find" the newest stable release and could download and install it over the build under test. Sparkle is therefore never started in a bare dev build: no scheduled check fires and the production feed is never contacted. A manual "Check for Updates…" stays available but surfaces a "disabled in development" notice instead.The update lab (
make update-test-*) is the one exception: it redirects the feed to a loopback server via LOCKIME_UPDATE_FEED, so the presence of that env var distinguishes the lab from a plain run and keeps its real download/install flow working. All new code is under #if DEBUG, leaving release builds unchanged.