Skip to content
This repository was archived by the owner on Nov 23, 2022. It is now read-only.

Upgrading Deps and Moving core and common from dev dependencies to dependencies (fixes monorepo bugs)#89

Open
JoeyEamigh wants to merge 2 commits into
onur-ozkan:masterfrom
JoeyEamigh:master
Open

Upgrading Deps and Moving core and common from dev dependencies to dependencies (fixes monorepo bugs)#89
JoeyEamigh wants to merge 2 commits into
onur-ozkan:masterfrom
JoeyEamigh:master

Conversation

@JoeyEamigh

Copy link
Copy Markdown
Contributor

Nestjs 8 requires rxjs 7 or greater, so I bumped the versions in this package. I am unsure if this is a breaking change for Nestjs 7.

@JoeyEamigh

Copy link
Copy Markdown
Contributor Author

This may not actually be necessary - I seem to have a bug in my monorepo that's causing this error. Going to investigate.

@JoeyEamigh

Copy link
Copy Markdown
Contributor Author

So it looks like the bug is that this package requires @nestjs/common and @nestjs/core but they were only listed in dev dependencies. This would normally never be an issue, but in a monorepo where packages are staggered between different node_modules folders, this package needs to explicitly declare those packages as dependencies or it will break.

@JoeyEamigh JoeyEamigh changed the title Upgrading deps to support Nestjs 8 Upgrading Deps and Moving core and common from dev dependencies to dependencies (fixes monorepo bugs) Jan 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant