Skip to content

Feature: Add new skos endpoints for schemes, collections and SKOS labels#15

Merged
alexskr merged 7 commits into
ontoportal:masterfrom
agroportal:pr/feature/add-skos-endpoints
Sep 19, 2025
Merged

Feature: Add new skos endpoints for schemes, collections and SKOS labels#15
alexskr merged 7 commits into
ontoportal:masterfrom
agroportal:pr/feature/add-skos-endpoints

Conversation

@syphax-bouazzouni

@syphax-bouazzouni syphax-bouazzouni commented Jun 23, 2025

Copy link
Copy Markdown
Contributor

Requires

Context

This PR add all the required endpoints to use the new SKOS features, see details here: agroportal#24

Changes

  • Add collection, schemes and skos labels endpoints and tests (4b5839e)
  • Update instance controller to use the Instance model (9c7b68f)
  • Update classes to endpoint to order or filter by an attribute, scheme or collection (c1b007a)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds new SKOS endpoints to support schemes, collections, and SKOS labels. It also updates tests and helper methods, and adjusts instance and class endpoints to include additional filtering, ordering, and unmapped handling.

  • Adds test coverage for new SKOS label, schemes, and collections endpoints.
  • Updates instance and class controllers for filtering and pagination.
  • Modifies helper methods to support the new endpoints and improves dependency sourcing in the Gemfile.

Reviewed Changes

Copilot reviewed 15 out of 17 changed files in this pull request and generated 2 comments.

File Description
test/controllers/* New tests for skos_xl_label, schemes, collections, and instances
helpers/* Added helper methods for schemes, collections, instances, and classes
controllers/* New endpoints and updated logic for SKOS labels, schemes, collections, instances, and classes
Gemfile Updated ontologies_linked_data dependency
Comments suppressed due to low confidence (1)

controllers/collection_controller.rb:1

  • The file is named 'collection_controller.rb', which does not match the declared class name 'CollectionsController'; consider renaming the file to 'collections_controller.rb'.
class CollectionsController < ApplicationController

Comment thread helpers/collections_helper.rb Outdated
Comment thread controllers/classes_controller.rb Outdated
@syphax-bouazzouni syphax-bouazzouni changed the title Feature: Add new skos endpoints for schemes, collectoins and SKOS labels Feature: Add new skos endpoints for schemes, collections and SKOS labels Aug 11, 2025
@alexskr alexskr merged commit 5975a4c into ontoportal:master Sep 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants