Skip to content

fix(chips): code in a chip's label stays inline, with no space after it - #229

Merged
vite-hub[bot] merged 1 commit into
mainfrom
fix/chips-html-inline-children
Oct 26, 2026
Merged

vite-hub[bot] merged 1 commit into
mainfrom
fix/chips-html-inline-children

Conversation

@onmax

@onmax onmax commented Oct 26, 2026

Copy link
Copy Markdown
Owner

The HTML renderer rendered a chip's label children without their parent, so comark took a <code> in the label for a top-level block and wrote a newline after it. [commit \5b5bd21`](…), builtcame out ascommit 5b5bd21\n`, which shows as a space between the code and the comma.

The renderer now passes the chip node as the parent to state.one. A new test covers it: it fails without the fix, and all 42 chips tests pass with it.

Drop carries this as a pnpm patch (vite-hub/drop@762e2478) until a comark-ui build with the fix is out.

🤖 Generated with Claude Code

@vite-hub

vite-hub Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor
Session Status Started Duration
Pending Completed Not started —

Latest result

Pull request merged.

Final answers

Session

Pull request merged.

Session

Waiting for review checks before the next pass.

Session

Waiting for review checks before the next pass.

Session

Waiting for review checks before the next pass.

Session

Waiting for review checks before the next pass.

Session

Waiting for review checks before the next pass.

Session

Waiting for review checks before the next pass.

Session

Waiting for review checks before the next pass.

Session

Waiting for review checks before the next pass.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes in the chips HTML renderer and its regression coverage.

  • Inline parent context — The renderer now passes the chip node to state.one, preserving inline rendering for code within a chip label and preventing whitespace before following punctuation.
  • Regression coverage — The public render test exercises an inline-code label followed immediately by a comma and asserts the exact boundary where the regression occurred.
  • Verification — pnpm --filter comark-chips test passes, and the chips package builds successfully after its local comark-zoom dependency is built.

Pullfrog  | View workflow run | Using gpt-5.6-sol | 𝕏

@vite-hub
vite-hub Bot merged commit 63b1398 into main Oct 26, 2026
8 of 9 checks passed
@vite-hub
vite-hub Bot deleted the fix/chips-html-inline-children branch October 26, 2026 20:03
This was referenced Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant