Repository navigation
fix(chips): code in a chip's label stays inline, with no space after it - #229
Merged
Merged
Conversation
Contributor
Latest result Pull request merged. Final answersSession Pull request merged. Session Waiting for review checks before the next pass. Session Waiting for review checks before the next pass. Session Waiting for review checks before the next pass. Session Waiting for review checks before the next pass. Session Waiting for review checks before the next pass. Session Waiting for review checks before the next pass. Session Waiting for review checks before the next pass. Session Waiting for review checks before the next pass. |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes in the chips HTML renderer and its regression coverage.
- Inline parent context — The renderer now passes the chip node to
state.one, preserving inline rendering for code within a chip label and preventing whitespace before following punctuation. - Regression coverage — The public render test exercises an inline-code label followed immediately by a comma and asserts the exact boundary where the regression occurred.
- Verification —
pnpm --filter comark-chips testpasses, and the chips package builds successfully after its localcomark-zoomdependency is built.
gpt-5.6-sol | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The HTML renderer rendered a chip's label children without their parent, so comark took a
<code>in the label for a top-level block and wrote a newline after it.[commit \5b5bd21`](…), builtcame out ascommit5b5bd21\n`, which shows as a space between the code and the comma.The renderer now passes the chip node as the parent to
state.one. A new test covers it: it fails without the fix, and all 42 chips tests pass with it.Drop carries this as a pnpm patch (vite-hub/drop@762e2478) until a comark-ui build with the fix is out.
🤖 Generated with Claude Code