Add support for SnapHelpers that display multiple items after a snap event#144
Open
MertNYuksel wants to merge 2 commits into
Open
Add support for SnapHelpers that display multiple items after a snap event#144MertNYuksel wants to merge 2 commits into
MertNYuksel wants to merge 2 commits into
Conversation
…ndicator index and item count relationship. This way we can use CircleIndicator2 with SnapHelpers that supports more than one item on a single webpage such as SnapToBlock. (https://stackoverflow.com/a/47580753/6644987) - Create SnapIndexController interface - Delegate all calls that related to indicator index and indicator count to SnapIndexController in CircleIndicator2 class. - Create SimpleSnapIndexController class for SnapHelpers that shows a single item on a single page. - Add an overloading attachToRecyclerView method to CircleIndicator2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CircleIndicator2 works fine with SnapHelpers like PagerSnapHelper since they only show a single recycler view item after a snap event. But it's not possible to use it with SnapHelpers such as SnapToBlock SnapHelper because they don't have one to one relationship between items and indicators. SnapToBlock SnapHelper
So in this pull request, I created SnapIndexController interface to abstract out SnapHelper, indicator index and item count relationship.